[FIX] event: access issue for event admin to event templates #117089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanna350
force-pushed
the
15.0-opw-3103199-event-template-access-fix-hale
branch
from
422d22a
to
fe6b1e3
Compare
joanna350
changed the title
joanna350
force-pushed
the
15.0-opw-3103199-event-template-access-fix-hale
branch
2 times, most recently
from
a58433a
to
cde3f8e
Compare
joanna350
commented
Mar 30, 2023
| notification_model = self.notification_type.replace('_', '.') + '.template' | ||
| model = self.env[notification_model] | ||
| try: | ||
| model.search_count([('model', '=', 'event.registration')]) |
There was a problem hiding this comment.
@nle-odoo if you agree this is better than hardcoded parts in previous PRs, will update on the newly raised PRs
nle-odoo
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
looks ok to me
this would have the same issue than the PR for event.mail, so we should see how #116469 (comment) ends before doing this.
joanna350
force-pushed
the
15.0-opw-3103199-event-template-access-fix-hale
branch
2 times, most recently
from
1ae95dd
to
9fe3664
Compare
1. Install Events 2. Settings - Users - Ensure one has Admin:Settings, another Event:Administrator - Click gear icon to set password 3. Try the step 4 with admin settings vs event admin 4. Click on the Event app - [Configuration] - [Event Templates] - Communication tab - select any on Send column Issue: It works not for Event Admin to edit the tab Resolve by: Workaround to access ir.model Impacted version: 15.0 - master opw-3103199
joanna350
force-pushed
the
15.0-opw-3103199-event-template-access-fix-hale
branch
from
9fe3664
to
b9b09d5
Compare
joanna350
commented
Mar 31, 2023
| @@ -67,6 +69,19 @@ def _prepare_event_mail_values(self): | |||
| 'template_ref': '%s,%i' % (self.template_ref._name, self.template_ref.id) | |||
| } | |||
|
|
|||
| @api.onchange('notification_type') | |||
| def set_template_ref_model(self): | |||
| notification_model = self.template_model_id.model | |||
There was a problem hiding this comment.
Hm, tested this to work..do correct me if I'm wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install Events
Settings - Users
Try the step 4 with admin settings vs event admin
Click on the Event app
Issue: It works not for Event Admin to edit the tab
Resolve by: Workaround to access ir.model
Impacted version: 15.0 - master
opw-3103199