[FIX] web: reintroduce .bg-transparent class
#121390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
1a68cbf
to
5e48ace
Compare
chgo-odoo
changed the title
.bg-transparent class.bg-transparent class
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
5e48ace
to
d8bca59
Compare
|
@chgo-odoo thanks and sorry for the late reply. Reminder: you should target 16.3 now |
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
2 times, most recently
from
63fa997
to
b4b3d47
Compare
chgo-odoo
changed the title
.bg-transparent class.bg-transparent class
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
b4b3d47
to
56ae012
Compare
stefanorigano
requested changes
May 19, 2023
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
56ae012
to
b31edce
Compare
|
@stefanorigano Changes done, I also removed the map-merge for the background part. Visually, it woks. Is it technically good? |
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
b31edce
to
f6358b2
Compare
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
f6358b2
to
cadc2e6
Compare
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
cadc2e6
to
f8aa53c
Compare
|
@stefanorigano Changes done and comment updated, how does that look? |
stefanorigano
approved these changes
May 26, 2023
There was a problem hiding this comment.
Thanks @chgo-odoo , just remove the changes in the section's description.
LGTM, ready for tech review 👍
Could you ping [@]pparidans once confirmed green on runbot? Thanks!
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
f8aa53c
to
bb56740
Compare
C3POdoo
requested review from
a team,
pro-odoo and
juliusc2066
and removed request for
a team
|
Hi @pparidans 👋 Could you have a look at this small PR, please? Wishing you a good longer weekend already ! |
pparidans
reviewed
May 30, 2023
There was a problem hiding this comment.
@stefanorigano @chgo-odoo thanks for the explanation.
@chgo-odoo could you just check the commit's message ? (not sure that talking about "key" and fixing syntax is still relevant)
== ISSUE == With the refactoring of the `utilities_custom.scss` file, we moved our custom `bg-*` classes to the `bootstrap_review_backend.scss` file. While doing this, the `bg-transparent` class actually disappeared. This commit aims to reintroduce the class in the backend. == After this commit == We reintroduce the `.bg-transparent` class inside the `bootstrap_review_backend` file. We adopt the default Bootstrap behavior for `background` classes and use a CSS variable to handle the opacity. task-3326297 part of task-3326263
chgo-odoo
force-pushed
the
master-milk-bringing-bg-transparent-back-chgo
branch
from
bb56740
to
e22e58a
Compare
|
@pparidans Thanks for reviewing ! The commit message has been updated as suggested. I also added a little explanation about how we build that class. How does that look? |
robodoo
pushed a commit
that referenced
this pull request
May 31, 2023
== ISSUE == With the refactoring of the `utilities_custom.scss` file, we moved our custom `bg-*` classes to the `bootstrap_review_backend.scss` file. While doing this, the `bg-transparent` class actually disappeared. This commit aims to reintroduce the class in the backend. == After this commit == We reintroduce the `.bg-transparent` class inside the `bootstrap_review_backend` file. We adopt the default Bootstrap behavior for `background` classes and use a CSS variable to handle the opacity. task-3326297 part of task-3326263 closes #121390 Signed-off-by: Pierre Paridans (app) <app@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 31, 2023
== ISSUE == With the refactoring of the `utilities_custom.scss` file, we moved our custom `bg-*` classes to the `bootstrap_review_backend.scss` file. While doing this, the `bg-transparent` class actually disappeared. This commit aims to reintroduce the class in the backend. == After this commit == We reintroduce the `.bg-transparent` class inside the `bootstrap_review_backend` file. We adopt the default Bootstrap behavior for `background` classes and use a CSS variable to handle the opacity. task-3326297 part of task-3326263 closes #121390 Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== ISSUE ==
With the refactoring of the
utilities_custom.scssfile, the transparent key from the map actually disappeared. This commit aims to reintroduce the key in order to make the class work.We also fix some synthax.
== After this commit ==
We reintroduce the
.bg-transparentclass inside theutilities_customfile. This allow us to extend the default BS's maps rather than override them.task-3326297
part of task-3326263
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr