[FW][FIX] hr_holidays: make test_current_leave_status deterministic #122826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_current_leave_status checks the correct implementation of different hr.leave computed fields. To do this, a leave is created, during the test. The test fails however, when the employee is not supposed to work during the leave period, which can happen when running the test on certain days. The test is made deterministic again by adding the number_of_days field to the dict. As this is a stored field, the created leave entry will be considered valid. X-original-commit: a1dffd3
|
This PR targets 15.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
May 30, 2023
The test_current_leave_status checks the correct implementation of different hr.leave computed fields. To do this, a leave is created, during the test. The test fails however, when the employee is not supposed to work during the leave period, which can happen when running the test on certain days. The test is made deterministic again by adding the number_of_days field to the dict. As this is a stored field, the created leave entry will be considered valid. closes #122826 X-original-commit: a1dffd3 Signed-off-by: Kevin Baptiste <kba@odoo.com>
fw-bot
deleted the
15.0-14.0-hr_holidays-indeterministic_test-tdc-yC6L-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_current_leave_statuschecks the correct implementation of differenthr.leavecomputed fields. To do this, a leave is created, during the test. The test fails however, when the employee is not supposed to work during the leave period, which can happen when running the test on certain days. The test is made deterministic again by adding thenumber_of_daysfield to the dict. As this is a stored field, the created leave entry will be considered valid.Closes #119591
Forward-Port-Of: #121533