[IMP] account: Remove _compute_is_move_sent #125392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since odoo@a5aefc7 this compute is no longer necessary
|
|
epictete
approved these changes
Jun 16, 2023
iada-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
Current Behavior: `is_move_sent` is not updated if there is an existing `invoice_pdf_report_id`. Purpose of this PR: Remove the `invoice_pdf_report_id` when resetting invoice to draft so that when the invoice is sent again (using the Send and Print wizard), `is_move_sent` is updated. Steps to Reproduce on Runbot: 1) Create and Send and Print invoice. (`is_move_sent` is set to True) 2) Reset invoice to draft. (`is_move_sent` is set to False) 3) Confirm and resend invoice using Send and Print wizard. (`is_move_sent` remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in Odoo 17 with this PR odoo#125392 `is_move_sent` is not updated when on the second Send and Print because of the existing `invoice_pdf_report_id` (generated and linked during the first Send and Print). opw-3849109
iada-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in Odoo 17 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
iada-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in Odoo 17 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
iada-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in Odoo 17 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
iada-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in Odoo 17 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
iada-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 17, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in saas-16.3 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
iada-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jun 6, 2024
Current Behavior: is_move_sent is not updated if there is an existing invoice_pdf_report_id. Purpose of this PR: Remove the `is_move_sent`: False on when resetting the account move to draft. This guarantees, that once the move has been sent via action_send_and_print, it will be marked as sent. Steps to Reproduce on Runbot: Create and Send and Print invoice. (is_move_sent is set to True) Reset invoice to draft. (is_move_sent is set to False) Confirm and resend invoice using Send and Print wizard. (is_move_sent remains False, expected to be changed to True) Notes: This PR odoo#116698 added a _compute in Odoo 16, however it was removed in saas-16.3 with this PR odoo#125392. is_move_sent is not updated on the second Send and Print because of the existing invoice_pdf_report_id (generated and linked during the first Send and Print). opw-3849109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a5aefc7 this compute is no longer necessary
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr