[IMP] l10n_pe: Clean the manifest, remove to-dos #129186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
added
CLA
|
@fvz-odoo the name of the commit must follow this format: https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html#commit-message-structure, can you take a look and update it pls. Thank you. |
|
@ren-odoo done! |
fvz-odoo
changed the title
When l10n_pe was initially developed, there were two unresolved matters that needed clarification for the users. However, with this recent commit, the manifest has been cleaned up, and now the explanation of the module is much clearer and easily understandable for the users.”
|
Should I close this pr? |
|
Hello @Levizar How about merging it? Or should I do something differently? Cheers! Fernando |
robodoo
pushed a commit
that referenced
this pull request
Feb 23, 2024
When l10n_pe was initially developed, there were two unresolved matters that needed clarification for the users. However, with this recent commit, the manifest has been cleaned up, and now the explanation of the module is much clearer and easily understandable for the users.” closes #129186 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
This was referenced Feb 23, 2024
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 1, 2024
When l10n_pe was initially developed, there were two unresolved matters that needed clarification for the users. However, with this recent commit, the manifest has been cleaned up, and now the explanation of the module is much clearer and easily understandable for the users.” closes odoo/odoo#129186 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
kaynnan
pushed a commit
to Escodoo/OCB
that referenced
this pull request
Mar 25, 2024
When l10n_pe was initially developed, there were two unresolved matters that needed clarification for the users. However, with this recent commit, the manifest has been cleaned up, and now the explanation of the module is much clearer and easily understandable for the users.” closes odoo#129186 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the manifest for the base module in Peru contains two pending tasks that need further clarification. These to-dos have remained unresolved since the module's inception four years ago. However, with this recent commit, we have provided a clearer explanation of what the module offers and have addressed and resolved the pending to-dos.
Task id=3337432