[FW][FIX] base: traceback on rpc call if data contain default dict #131123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this commit, on reading data with default dict data type is showing error to end user, without returning the requested data. for eg, if a read operation is triggered on model sale.order it wont return the requested data, instead traceback is shown in response. in sale.order model the tax_totals field is a computed field, with data as format default dict which was causing the issue. after this commit, without any traceback the requested data will be returned to the user. X-original-commit: cc61b92
|
@niyasraphy @Julien00859 this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 8, 2023
before this commit, on reading data with default dict data type is showing error to end user, without returning the requested data. for eg, if a read operation is triggered on model sale.order it wont return the requested data, instead traceback is shown in response. in sale.order model the tax_totals field is a computed field, with data as format default dict which was causing the issue. after this commit, without any traceback the requested data will be returned to the user. closes #131123 X-original-commit: cc61b92 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Aug 8, 2023
before this commit, on reading data with default dict data type is showing error to end user, without returning the requested data. for eg, if a read operation is triggered on model sale.order it wont return the requested data, instead traceback is shown in response. in sale.order model the tax_totals field is a computed field, with data as format default dict which was causing the issue. after this commit, without any traceback the requested data will be returned to the user. closes #131123 X-original-commit: cc61b92 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this commit, on reading data with default dict data type is showing error to end user, without returning the requested data.
for eg, if a read operation is triggered on model sale.order it wont return the requested data, instead traceback is shown in response.
in sale.order model the tax_totals field is a computed field, with data as format default dict which was
causing the issue.
after this commit, without any traceback the requested data will be returned to the user.
Issue: #129183
Issue: #129494
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #129830