[FIX] website_sale: sale ribbons disappearing

[ande-odoo]

Current behaviour:

When removing the ribbon from a product,
the other ribbons are removed as well.

Steps to reproduce:

1. Go to website
2. Go to Shop
3. Click on Edit (top right)
4. Add a ribbon to multiple products
5. Click on Save
6. Select a product with a ribbon
7. Remove the ribbon
8. (other ribbons are gone)

Cause of the issue:

Reverting fix introduced by 5d13fa5
t-out was modified into t-field to be considered dirty when modified.
but when removing a ribbon, t-field is set as empty,
which overwrites ribbons html value.

opw-3487397

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

[loco-odoo]

Hello @ande-odoo 👋
While testing your PR, I reported few stuffs ;)

• The o_dirty class is added on the ribbon when clicking on the image. IMO, this should not be the case and this class should only be added when modifying the ribbon. (to solve the problem, the editor observer should probably be paused somewhere (grep odooEditor.observerUnactive)).
• Sometime, when you create a new badge, the o_dirty class is still there after the saving and if you try to remove the ribbon afterwards, it does not work.

I made a video to make thinks clearer ;)
Screencast from 09-25-2023 02:16:54 PM.webm

[loco-odoo]

Hello @ande-odoo 👋
I had a look on why the o_dirty class is added on the ribbon when you click on an image product and it seems to come from the insertion and remove of the o_we_force_no_transition class in the _computeWidgetState() logic of the SnippetOptionWidget (addons/web_editor/static/src/js/editor/snippets.options.js). If you pause the observer while adding and removing this class, the o_dirty class will not be added on the ribbon when you click on the product image ;)

[ande-odoo]

After investigation, only reverting my previous PR fixes it, it probably has been fixed somewhere else in the meanwhile. I have updated this PR to only revert my previous fix.

[qsm-odoo]

Confirmed 😬 What was done at 5d13fa5 should not have been merged cc @AntoineVDV

• Template XML change in an old stable version
• It worked before like that: the template could not have been the sole change needed

Not really a fan of changing the XML again but I guess more people are using the old version so I guess a revert 3 months later is ok.

@ande-odoo

• What happened to the change that was discussed here: [FIX] website_sale: sale ribbons disappearing #135908 (comment) ? Did you create another PR about it?
• Testing this, I saw another bug: cannot change the ribbon colors. I guess you saw it too? Did you create a task in eCommerce pipe or in ours?

@robodoo r+

[qsm-odoo]

@ande-odoo ?

[qsm-odoo]

I guess I can forget about receiving an answer..

Testing this, I saw another bug: cannot change the ribbon colors.

Apparently solved now, maybe with the help of #152694

What happened to the change that was discussed here [...]

Created task-3734908 to handle that.