[FIX] core: harden the legacy migrations package matching regex
#136282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since odoo#122569, we now try to import the `migrations` sub-package of each module to find upgrade tests. However, this badly written regex match the OCA module `base_maintenance`, which generate a RecursionError.
|
@pedrobaeza Can you test if this solves your problem? |
C3POdoo
requested review from
a team,
rco-odoo and
ryv-odoo
and removed request for
a team
pedrobaeza
approved these changes
Sep 22, 2023
|
@robodoo r+ |
This was referenced Sep 25, 2023
erl-odoo
referenced
this pull request
Sep 26, 2023
Upgrade (aka migration) scripts are a core part of Odoo, allowing database manipulations for modules during version changes. Any module, including custom ones can run upgrade scripts, even if the `--upgrade-path` flag (and with it, the `odoo.upgrade` sub-module) is not present. Currently only the "standard" modules benefit of easy upgrade script testing. Any custom modules that want to run tests of their upgrades have to import the tests in the usual `tests` folder, which is not ideal. Therefore, to allow TDD and programmatic testing of upgrade scripts in custom modules, the test discovery is here modified to also parse the module's `migrations` and `upgrades` sub-modules for tests. closes #136130 X-original-commit: 483cc20 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com> Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>
|
@KangOl this pull request has forward-port PRs awaiting action (not merged or closed): |
etobella
added a commit
to etobella/odoo
that referenced
this pull request
Dec 11, 2023
Since odoo#122569, we now try to import the migrations sub-package of each module to find upgrade tests. However, this badly written regex match the OCA module base_maintenance, which generate a RecursionError. It was partially fixed on odoo#136282 but some collateral damages where raised on tests
robodoo
pushed a commit
that referenced
this pull request
Dec 11, 2023
Since #122569, we now try to import the migrations sub-package of each module to find upgrade tests. However, this badly written regex match the OCA module base_maintenance, which generate a RecursionError. It was partially fixed on #136282 but some collateral damages where raised on tests closes #145800 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
This was referenced Dec 13, 2023
luanjubica
pushed a commit
to luanjubica/odoo-code
that referenced
this pull request
Feb 14, 2024
Since odoo#122569, we now try to import the migrations sub-package of each module to find upgrade tests. However, this badly written regex match the OCA module base_maintenance, which generate a RecursionError. It was partially fixed on odoo#136282 but some collateral damages where raised on tests closes odoo#145800 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
aaronselk
pushed a commit
to continuant/odoo
that referenced
this pull request
Mar 28, 2024
Since odoo#122569, we now try to import the migrations sub-package of each module to find upgrade tests. However, this badly written regex match the OCA module base_maintenance, which generate a RecursionError. It was partially fixed on odoo#136282 but some collateral damages where raised on tests closes odoo#145800 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #122569, we now try to import the
migrationssub-package of each module to find upgrade tests.However, this badly written regex match the OCA module
base_maintenance, which generate a RecursionError.I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr