[IMP] rating_*: Improvement #13692
Merged
[IMP] rating_*: Improvement #13692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jat-odoo
force-pushed
the
master-rating-improvement-jat
branch
2 times, most recently
from
7f318ff
to
fd9d13e
Compare
rga-odoo
force-pushed
the
master-rating-improvement-jat
branch
from
fd9d13e
to
a2f8a51
Compare
jat-odoo
force-pushed
the
master-rating-improvement-jat
branch
2 times, most recently
from
0a4752c
to
ca09307
Compare
jat-odoo
force-pushed
the
master-rating-improvement-jat
branch
3 times, most recently
from
078e4da
to
29555ed
Compare
jat-odoo
force-pushed
the
master-rating-improvement-jat
branch
from
29555ed
to
d6b090a
Compare
jat-odoo
force-pushed
the
master-rating-improvement-jat
branch
2 times, most recently
from
778b664
to
84dd27a
Compare
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
7 times, most recently
from
fe2e96e
to
1c8e80a
Compare
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
2 times, most recently
from
4af7349
to
deab579
Compare
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
4 times, most recently
from
7be684d
to
7e303a9
Compare
tde-banana-odoo
requested changes
Dec 29, 2016
| res_model = fields.Char(string='Document Model', required=True, help="Model name of the rated object", index=True) | ||
| res_name = fields.Char(string='Resource name', compute='_compute_res_name', store=True, help="The name of the rated resource.") | ||
| res_model_id = fields.Many2one('ir.model', 'Related Document Model', index=True, ondelete='cascade', help='Model of the followed resource') | ||
| res_model = fields.Char(string='Document Model', related='res_model_id.model', store=True, index=True) |
There was a problem hiding this comment.
Probably add a readonly=True
| @@ -19,10 +19,11 @@ def write(self, values): | |||
| return res | |||
|
|
|||
| def _send_issue_rating_mail(self): | |||
| force_send = self.env.context.get('force_send', True) | |||
There was a problem hiding this comment.
Where is this context key used ? What is its purpose ?
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
from
7e303a9
to
232d984
Compare
| rating.rating_image = False | ||
|
|
||
| @api.multi | ||
| def _compute_rating_text(self): |
| message_id = fields.Many2one('mail.message', string="Linked message", help="Associated message when posting a review. Mainly used in website addons.", index=True) | ||
| access_token = fields.Char('Security Token', default=new_access_token, help="Access token to set the rating of the value") | ||
| consumed = fields.Boolean(string="Filled Rating", help="Enabled if the rating has been filled.") | ||
|
|
||
| @api.multi | ||
| def _compute_rating_image(self): |
| rating_count = fields.Integer('Rating count', compute="_compute_rating_count") | ||
|
|
||
| def write(self, values): |
There was a problem hiding this comment.
Write should be below computed fields ;)
| @@ -19,10 +19,11 @@ def write(self, values): | |||
| return res | |||
|
|
|||
| def _send_issue_rating_mail(self): | |||
| force_send = self.env.context.get('force_send', True) | |||
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
from
232d984
to
19f4815
Compare
In rating module - provide list and form view for rating - better kanban view (remove js code, ellispsis for long name, better feedback display, ...) - provide more field on the mixin to cover more case - update res_name of rating when the ressource name is changed (for consistency) - make the rating web page, a correct html page (by using web.layout template) - some guidelines compliance In rating_project and rating_project_issue: - add filter for rated document - some guidelines compliance
- use rating.mixin field instead of rating_ids to display rating on form view - clean controller method - ...
Automatically deleting a rating was not implemented yet. We find 2 cases : - when uninstalling a module, the same mecanism as mail.follower is used, via a res_model_id field pointing on ir.model. When this model does not exist anymore, remove all related rating. - when deleting a record, its rating should be deleted too.
jem-odoo
force-pushed
the
master-rating-improvement-jat
branch
from
5dca624
to
8e10f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
rating:-
rating_project:-