[IMP] portal, mail,...: Use backend chatter in portal #138233

maki-odoo · 2023-10-10T13:48:05Z

By this commit:

Portal chatter public widget is deleted
The chatter in portal is the backend Chatter component (from mail module) now
Some features in chatter like link preview and reactions are new in portal environment (number of queries in some tests are increased because of reactions feature on messages)
Except of two use cases of portal composer (as rating popup composer) all the other use cases of composer in portal, are replaced by composer component in mail module
The project sharing doesn't use the previous chatter component in the sharing webclient view. It's replaced by backend chatter component as well

P.S.

At the next step by converting rating popup composer, the portal composer public widget could be deleted completely as well

Task-2828744

Related enterprise PR

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2023-10-10T13:49:12Z

Pull request status dashboard.

addons/im_livechat/static/src/embed/core_ui/thread_patch.xml

addons/mail/controllers/attachment.py

tde-banana-odoo · 2024-03-29T15:24:33Z

addons/portal/models/mail_thread.py

+from odoo.addons.portal.controllers.mail import _check_special_access
+
+
+def check_portal_access(func):


You should probably avoid this kind of construct, as it makes code really hard to follow and understand, especially adding magic parameters. Why don't you improve the environment instead ? It seems to be the right place to store that kind of information, along user, lang, ... it seems more inlined with current code, in order to avoid this magic stuff.

cc @mart-e as it might interest you: isn't it the kind of stuff that should be done cleanly on environment ?

seb-odoo

Hello, I had a quick look again, not a complete review (especially not the security part) but I wanted to get a quick idea of the current diff and I had a few comments that came out of it.

seb-odoo · 2024-05-17T10:07:34Z

addons/mail/static/src/core/common/composer.js

-                cannedResponseIds: composer.cannedResponses.map((c) => c.id),
-                parentId: this.props.messageToReplyTo?.message?.id,
-            };
+            const postData = this.postData(composer);


This could be composer.postData() and use this inside the function

seb-odoo · 2024-05-17T10:08:05Z

addons/mail/static/src/core/common/composer.js

            await this._sendMessage(value, postData);
        });
    }

+    postData(composer) {


This name looks like the function will post data, maybe getPostData?

seb-odoo · 2024-05-17T10:08:28Z

addons/mail/static/src/core/common/composer.xml

@@ -14,7 +14,7 @@
                    'p-3': normal,
                    'o-hasSelfAvatar': !env.inChatWindow and thread,
                }" t-attf-class="{{ props.className }}">
-            <div class="o-mail-Composer-sidebarMain flex-shrink-0" t-if="!compact and props.sidebar">
+            <div class="o-mail-Composer-sidebarMain flex-shrink-0" t-if="!compact and props.sidebar" name="sidebar main">


name is not really necessary in this case, it could target the class o-mail-Composer-sidebarMain.

seb-odoo · 2024-05-17T10:10:13Z

addons/mail/static/src/core/common/message.xml

@@ -63,6 +63,7 @@
                        </div>
                        <div
                            class="position-relative d-flex"
+                            name="message content"


We often don't pay too much attention to that, but technically (in HTML) name is not a valid attribute for div elements.

Maybe we should have a specific class instead, or for custom data we should use data- something.

seb-odoo · 2024-05-17T10:11:45Z

addons/account/tests/test_portal_attachment.py

+        # Only messages from the current user not OdooBot
+        messages = self.out_invoice.message_ids.filtered(lambda msg: msg.author_id == self.partner_a)
+        self.assertEqual(len(messages), 3)
+        self.assertEqual(messages[0].body, "<p>test message 3</p>")
+        self.assertEqual(len(messages[0].attachment_ids), 1)


Why is the test changed? Where the extra message (from odoo bot) coming from compared to before the PR?

From _message_post_after_hook() which is called by message_post. The previous method was portal_chatter_post without calling _message_post_after_hook()

seb-odoo · 2024-05-17T10:25:02Z

addons/im_livechat/static/src/embed/common/thread_patch.xml

@@ -6,7 +6,7 @@
                <Message message="props.thread.livechatWelcomeMessage" hasActions="false" thread="props.thread" className="'px-3'"/>
            </div>
        </xpath>
-        <xpath expr="//*[@name='content']" position="after">
+        <xpath expr="(//div[hasclass('o-mail-Thread')])[last()]" position="after">


What is this change?

I can't reproduce it now, but I remember there was a bug in isTyping when there were no content on the thread. I see the typing part is changed in livechat already.

seb-odoo · 2024-05-17T10:27:18Z

addons/mail/static/src/utils/common/hooks.js

@@ -45,7 +45,7 @@ export function onExternalClick(refName, cb) {
    let downTarget, upTarget;
    const ref = useRef(refName);
    function onClick(ev) {
-        if (ref.el && !ref.el.contains(ev.target)) {
+        if (ref.el && !ref.el.contains(ev.composedPath()[0])) {


Is there a bug here? Can't it be fixed separately?

This bug is introduced in this PR when we have three overlays together on the page, and we want that external click knows exactly which overlay should be affected and closed. I can make a separate fix, but I can't reproduce it there.

seb-odoo · 2024-05-17T10:28:07Z

addons/portal/__manifest__.py

+            'mail/static/src/discuss/typing/**/*',
+            'mail/static/src/discuss/core/common/action_panel.*',
+        ],
+        'portal.assets_embed': [


What is embed portal?

The bundle that provides the shadow dom's requirements.

seb-odoo · 2024-05-17T10:33:55Z

addons/portal_rating/static/src/chatter/frontend/composer_patch.xml

+            </div>
+        </xpath>
+    </t>
+</templates>


missing new line

seb-odoo · 2024-05-17T10:34:49Z

addons/website_slides/static/tests/tours/slides_course_member.js

+        // The popup composer still works with public widget and till the user refreshs the page, the comment's change is not visible.
+        // Todo: Uncomment it when the popup composer would be converted to a component
+        //{
+        //    shadow_dom: "#chatterRoot",
+        //    trigger: '.o-mail-Message-content:contains("This is a great course. Top !")',
+        //    run: function () {}, // check review is correctly added
+        //}


Commented code

It's an intended comment with Todo for the next PR, when we're going to replace and delete old portal rating composer as well. This part of the test should be reverted when it's possible to fetch after posting via new rating composer in elearning.

qsm-odoo

Hello 👋 Two comments without checking the purpose or checking the code:

This represents a 39% increase of frontend JS bundle when only website is installed. Something has to be done: probably lazy loading what is required when the feature is used.
We have multiple work planned regarding those JS bundle, one currently being done is removing jQuery (this is being done through multiple (India) PR, one step at a time, we'll ping the relevant teams when we are confident each step is done properly). If you are to introduce that much of an increase of frontend JS, lazy loaded or not, it would be nice if it could not contain any jQuery already 🙏

Thanks 🙏

stefanorigano · 2024-05-27T16:13:50Z

Hei there, cool task 👋
2 generic notes/questions from @odoo/rd-design :

The "bubble design" doesn't match all business needs out there. This PR should provide a website's option to "reset" the design to a more consolidated/generic one I guess, is it planned?
At the current state, the chatter doesn't adapt to the website palette (see screenshoot). Is it something that's supposed to be addressed right ?

master	this PR

Thanks!

By this commit: - Portal chatter widget is deleted - The chatter in portal is the backend Chatter component (from mail module) now - Some features in chatter like link preview and reactions are new in portal environment (number of queries in some tests are increased because of reactions feature on messages) - Except of two use cases of portal composer (as a popup composer) all the other use cases of composer in portal, are replaced by composer component in mail module - The project sharing doesn't use the previous chatter component in the sharing webclient view. It's replaced by backend chatter component as well task-2828744

Remove authentication via rpc calls and move all security parameters to the kwargs parameters

C3POdoo added the RD research & development, internal work label Oct 10, 2023

maki-odoo force-pushed the master-backend_chatter_portal-maki branch 13 times, most recently from 45a3eb9 to 64a6743 Compare October 11, 2023 16:29

phenix-factory reviewed Oct 12, 2023

View reviewed changes

addons/im_livechat/static/src/embed/core_ui/thread_patch.xml Outdated Show resolved Hide resolved

maki-odoo marked this pull request as ready for review October 12, 2023 07:12

C3POdoo requested review from a team, brboi and Polymorphe57 and removed request for a team October 12, 2023 07:13

maki-odoo force-pushed the master-backend_chatter_portal-maki branch from 64a6743 to e327ec0 Compare October 12, 2023 07:23

tde-banana-odoo reviewed Oct 12, 2023

View reviewed changes

addons/mail/controllers/attachment.py Outdated Show resolved Hide resolved

maki-odoo force-pushed the master-backend_chatter_portal-maki branch from 1c14d71 to 93b48a3 Compare October 12, 2023 08:50

maki-odoo force-pushed the master-backend_chatter_portal-maki branch 4 times, most recently from 0e4da69 to 4571ebb Compare March 27, 2024 14:30

tde-banana-odoo reviewed Mar 29, 2024

View reviewed changes

maki-odoo marked this pull request as draft April 15, 2024 13:04

maki-odoo force-pushed the master-backend_chatter_portal-maki branch 4 times, most recently from 55306f4 to 522cae0 Compare April 30, 2024 15:18

maki-odoo force-pushed the master-backend_chatter_portal-maki branch 6 times, most recently from 08fa636 to bdcc93c Compare May 8, 2024 12:24

maki-odoo force-pushed the master-backend_chatter_portal-maki branch 4 times, most recently from f9af2b2 to 35ca897 Compare May 17, 2024 09:56

seb-odoo reviewed May 17, 2024

View reviewed changes

qsm-odoo requested changes May 17, 2024

View reviewed changes

maki-odoo force-pushed the master-backend_chatter_portal-maki branch from 35ca897 to 6474f6f Compare May 17, 2024 13:53

maki-odoo added 5 commits June 6, 2024 16:25

[IMP] project: use mention suggestion in project webclient sharing

2b2c275

[IMP] mail, *: one way to authenticate

22dbcbe

Remove authentication via rpc calls and move all security parameters to the kwargs parameters

[IMP] project: adapt with new follow/unfollow feature

ef471a6

[IMP] portal: Sync style

cd77fa9

maki-odoo force-pushed the master-backend_chatter_portal-maki branch from 6474f6f to cd77fa9 Compare June 6, 2024 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] portal, mail,...: Use backend chatter in portal #138233

[IMP] portal, mail,...: Use backend chatter in portal #138233

maki-odoo commented Oct 10, 2023 •

edited

robodoo commented Oct 10, 2023

tde-banana-odoo Mar 29, 2024 •

edited

tde-banana-odoo Mar 29, 2024

seb-odoo left a comment

seb-odoo May 17, 2024

seb-odoo May 17, 2024

seb-odoo May 17, 2024

seb-odoo May 17, 2024

seb-odoo May 17, 2024

maki-odoo May 17, 2024

seb-odoo May 17, 2024

maki-odoo May 17, 2024

seb-odoo May 17, 2024

maki-odoo May 17, 2024

seb-odoo May 17, 2024

maki-odoo May 17, 2024

seb-odoo May 17, 2024

seb-odoo May 17, 2024

maki-odoo May 17, 2024

qsm-odoo left a comment

stefanorigano commented May 27, 2024 •

edited

		from odoo.addons.portal.controllers.mail import _check_special_access


		def check_portal_access(func):

[IMP] portal, mail,...: Use backend chatter in portal #138233

Are you sure you want to change the base?

[IMP] portal, mail,...: Use backend chatter in portal #138233

Conversation

maki-odoo commented Oct 10, 2023 • edited

robodoo commented Oct 10, 2023

tde-banana-odoo Mar 29, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seb-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qsm-odoo left a comment

Choose a reason for hiding this comment

stefanorigano commented May 27, 2024 • edited

maki-odoo commented Oct 10, 2023 •

edited

tde-banana-odoo Mar 29, 2024 •

edited

stefanorigano commented May 27, 2024 •

edited