[IMP] website: choose between radio or dropdown in select fields #138944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
5 times, most recently
from
539e4e4
to
2a86f65
Compare
Guillaume-gdi
requested changes
Feb 26, 2024
| @@ -289,13 +289,18 @@ | |||
| <t t-call="website.form_field"> | |||
| <select class="form-select s_website_form_input" t-att-name="field.name" t-att-required="field.required || field.modelRequired || None" t-att-id="field.id" style="display: none"> | |||
| <t t-foreach="field.records" t-as="record" t-key="record_index"> | |||
| <option t-esc="record.display_name" t-att-value="record.id" t-att-selected="record.selected and 'selected' or None"/> | |||
| <option t-attf-selected="#{record.selected and 'selected' or None}" t-esc="record.display_name" t-att-value="record.id"/> | |||
There was a problem hiding this comment.
Why this change ? And why do you change the order of attributes ?
There was a problem hiding this comment.
Following the changes introduced in 6303a3e, there is a bug affecting the behavior of t-att-selected, possibly introduced in the subsequent commit: 3632519. I've created a task (id:3767819). A work around to avoid waiting the forward-port in master, is to use t-attf instead. I could remove this change as soon as the bug is fixed.
There was a problem hiding this comment.
@Guillaume-gdi I took inspiration from the commit b42e9cc by @rdeodoo to address this issue, which will be resolved in the aforementioned task.
https://github.com/odoo/odoo/pull/138944/files#diff-e84353750393781d43d4a4bb1debe41db124f3b0ef9301e516f622695905d4b4R292
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
2 times, most recently
from
ad9d5fa
to
bc96432
Compare
SergeBayet
changed the title
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
from
bc96432
to
c42084c
Compare
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
5 times, most recently
from
783dc05
to
83a0023
Compare
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
from
83a0023
to
4d690c0
Compare
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
from
4d690c0
to
d01e21d
Compare
SergeBayet
changed the title
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
from
d01e21d
to
deabc84
Compare
SergeBayet
changed the title
bso-odoo
reviewed
Apr 23, 2024
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
2 times, most recently
from
044a994
to
681e32e
Compare
This task addresses the limitation where users do not have the option to choose between a select and radio button when dealing with existing fields. The goal is to facilitate a more informed choice between the two based on the number of available options. A new "Selection Type" option is added, allowing users to choose between Dropdown List and Radio for fields with a moderate number of options. The option fields are removed from the preview area, considering that the options are already displayed in the right panel. task-2232291
SergeBayet
force-pushed
the
master-select-field-radio-dropdown-seba
branch
from
681e32e
to
11d1832
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 24, 2024
This task addresses the limitation where users do not have the option to choose between a select and radio button when dealing with existing fields. The goal is to facilitate a more informed choice between the two based on the number of available options. A new "Selection Type" option is added, allowing users to choose between Dropdown List and Radio for fields with a moderate number of options. The option fields are removed from the preview area, considering that the options are already displayed in the right panel. task-2232291 closes #138944 Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
This task addresses the limitation where users do not have the option to choose between a select and radio button when dealing with existing fields. The goal is to facilitate a more informed choice between the two based on the number of available options. A new "Selection Type" option is added, allowing users to choose between Dropdown List and Radio for fields with a moderate number of options. The option fields are removed from the preview area, considering that the options are already displayed in the right panel. task-2232291 closes odoo#138944 Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task addresses the limitation where users do not have the option
to choose between a select and radio button when dealing with existing
fields. The goal is to facilitate a more informed choice between the
two based on the number of available options.
A new "Selection Type" option is added, allowing users to choose between
Dropdown List and Radio for fields with a moderate number of options.
The option fields are removed from the preview area, considering that
the options are already displayed in the right panel.
task-2232291