[REF] *: fill all missing static props #143209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
juliusc2066
changed the title
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
7 times, most recently
from
9aca0e1
to
53a2405
Compare
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
9 times, most recently
from
90e2a23
to
fef7a74
Compare
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
5 times, most recently
from
14d6e99
to
5c0e993
Compare
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
4 times, most recently
from
b788bb5
to
cd3c51e
Compare
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
2 times, most recently
from
59a0f12
to
4f9de5e
Compare
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
5 times, most recently
from
2db2a62
to
a8b36a4
Compare
This commit moves the profiling folder from web/core to web/webclient since all of its content is only used inside of the webclient and it also fix some potential dependency issues of defining a field inside of core (in the profiling_qweb file).
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
from
a8b36a4
to
007611c
Compare
This commit adds static props to all component that don't define it. This makes props validation universal throughout the code base which helps for code clarity and consistency. It also adds rules to the test linter so that the definition of static props and static template are mandatory on each component of the codebase and enables props validation in test mode. It also forces the props and template declarations to be done inside of the component's definition so declaring them after the class definition will now be considered as a linting error. task-3594598
juliusc2066
force-pushed
the
master-fill-static-props-everywhere-juca
branch
from
007611c
to
ec9b2ef
Compare
|
robodoo rebase-ff r+ p-0 |
|
Merge method set to rebase and fast-forward. |
|
robodoo p=0 |
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2024
This commit moves the profiling folder from web/core to web/webclient since all of its content is only used inside of the webclient and it also fix some potential dependency issues of defining a field inside of core (in the profiling_qweb file). Part-of: #143209
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2024
This commit adds static props to all component that don't define it. This makes props validation universal throughout the code base which helps for code clarity and consistency. It also adds rules to the test linter so that the definition of static props and static template are mandatory on each component of the codebase and enables props validation in test mode. It also forces the props and template declarations to be done inside of the component's definition so declaring them after the class definition will now be considered as a linting error. task-3594598 closes #143209 Related: odoo/enterprise#51293 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
juliusc2066
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 30, 2024
This commit ensures tests are run in debug mode so that props validation is required for tests to pass. This was supposed to be part of odoo#143209 but was mistakenly removed by a conflict.
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2024
This commit ensures tests are run in debug mode so that props validation is required for tests to pass. This was supposed to be part of #143209 but was mistakenly removed by a conflict. closes #151027 Related: odoo/enterprise#55110 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit moves the profiling folder from web/core to web/webclient since all of its content is only used inside of the webclient and it also fix some dependency issues of defining a field inside of core (in the profiling_qweb file) introduced by the second commit.
Second commit adds static props to all component that don't define it. This makes props validation universal throughout the code base which helps for code clarity and consistency. It also adds rules to the test linter so that the definition of static props and static template are mandatory on each component of the codebase and enables props validation in test mode. It also forces the props and template declarations to be done inside of the component's definition so declaring them after the class definition will now be considered as a linting error.
task-3594598