[FIX] project: Saving and Task Creation Issues #143282

mjvi-odoo · 2023-11-23T06:42:22Z

Current behavior before PR:

Unable to save subtasks when adding a project.
Traceback occurs when creating a new task from the subtask kanban view in project sharing.

Desired behavior after PR is merged:

Enable successful saving of subtasks after adding a project.
Resolve traceback issue during new task creation in project sharing, ensuring correct task creation without traceback.

task-3584963

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2023-11-23T06:43:08Z

Pull request status dashboard.

pkyriakou

Thank you @mjvi-odoo for your work 💯
I left one comment for you, its a bit long but I think it should be helpful for the first bug. If you have any questions feel free to shoot me a message on Discord.

pkyriakou · 2023-12-08T13:47:57Z

addons/project/static/src/components/project_many2one_field/project_many2one_field.js

I do not think that this is really solving the bug reported.
What this method does is that it hides the project that the subtask has by default because we want to give the user the choice for whether they want the subtask to be shown or not in the project's views.
By removing this method, we remove that functionality which in this case is not correct.
The problem stems from a different place and it is here
Because the display_in_project field is readonly and we don't specify the forcesave attribute, this method doesn't include it in its changes and thus doesn't allow the user to save.
We can add the force_save attribute in the xml of the field as you can see from the parser

Hello @pkyriakou, I did changes as per you suggested and removed force_save from display_in_project field.

pkyriakou

Thank you for your updates @mjvi-odoo
I left you some more comments.

pkyriakou · 2023-12-13T09:00:45Z

addons/project/views/project_sharing_project_task_views.xml

Hey @mjvi-odoo thank you for your changes but are you sure that this will fully solve the traceback on portal ?
As you can see here, the error stems from the recurrence_id field.

Yes, I confirm that the changes resolve the traceback issue with the recurrence_id field. @pkyriakou

pkyriakou · 2023-12-13T09:48:28Z

addons/project/views/project_task_views.xml

@@ -383,7 +383,7 @@
                                   widget="subtasks_one2many">
                                <tree editable="bottom" decoration-muted="state in ['1_done','1_canceled']" open_form_view="True">
                                    <field name="allow_milestones" column_invisible="True"/>
-                                    <field name="display_in_project" column_invisible="True" force_save="1"/>
+                                    <field name="display_in_project" column_invisible="True"/>


Actually your change here is not correct, removing the force_save here will just further break the feature. What the problem is is that the display_in_project field does not appear in the base task form and thus the force_save is not inside the activeFields in the record class.
What you should do is add this line:

<field name="display_in_project" invisible="True" force_save="1"/>

in line 339 under the project_id field.

understood, I have made the changes as per your comment. @pkyriakou

pkyriakou

Alright then, I have nothing else to comment on, thank you for the changes ✌️

pkyriakou

Hello @mjvi-odoo I added a question for you to look into 💪

pkyriakou · 2024-01-05T15:09:47Z

addons/project/views/project_task_views.xml

@@ -529,7 +530,8 @@
                    <group>
                        <field name="project_id" invisible="1" />
                        <field name="company_id" invisible="1" />
-                        <field name="parent_id" domain="[('id', '!=', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" /> 
+                        <field name="child_ids" invisible="1" />
+                        <field name="parent_id" domain="[('id', '!=', id), ('id', 'not in', child_ids), ('parent_id.id', 'not in', child_ids)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" />


Why is the third part needed for the domain ? the ('parent_id.id', 'not in', child_ids)

I have added this third part to restrict sub-sub-task, but now I have updated code and added: '!', ('id', 'child_of', id)

pkyriakou

Thank you @mjvi-odoo for the update. I left two minor comments regarding formatting 😁

pkyriakou · 2024-01-11T15:28:09Z

addons/project/views/project_task_views.xml

+                        <field name="child_ids" invisible="1" />
+                        <field name="parent_id" domain="[('id', '!=', id),'!', ('id', 'child_of', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" />


Suggested change

<field name="child_ids" invisible="1" />

<field name="parent_id" domain="[('id', '!=', id),'!', ('id', 'child_of', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" />

<field name="child_ids" invisible="1"/>

<field name="parent_id" domain="[('id', '!=', id), '!', ('id', 'child_of', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" />

Just formatting

pkyriakou · 2024-01-11T15:28:44Z

addons/project/views/project_sharing_project_task_views.xml

@@ -140,7 +140,7 @@
                            </div>
                        </button>
                        <button name="action_project_sharing_open_subtasks" type="object" class="oe_stat_button" icon="fa-tasks"
-                            invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])]}">
+                            invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])],'default_project_id': project_id }">


Suggested change

invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])],'default_project_id': project_id }">

invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])], 'default_project_id': project_id }">

auon-odoo

Thanks for the fix

xavierbol · 2024-03-27T12:19:24Z

addons/project/views/project_task_views.xml

@@ -529,7 +530,8 @@
                    <group>
                        <field name="project_id" invisible="1" />
                        <field name="company_id" invisible="1" />
-                        <field name="parent_id" domain="[('id', '!=', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" /> 
+                        <field name="child_ids" invisible="1"/>


Why is it needed in the view? 🤔

my bad 🙈

Steps to reproduce: - Access the 'project.task' module. - Create a subtask. - Attempt to save the subtask after adding a project to it. Issue: - Saving a subtask becomes impossible when a project is added, causing an obstruction in the process. Solution: - Rectify the functionality to enable successful saving of a subtask even after adding a project, ensuring a seamless process for subtask creation and association with projects. task-3584963

Steps to reproduce: - In 'project sharing' create a task T in project A. - Add 2 subtasks to task T in project A. - Share project A in edit mode. - Access the view form of task T as a portal user. - Click on the subtask button to navigate to the tree/kanban view of subtasks. - Select the kanban view. - Create a new task on the fly, resulting in a traceback. Issue: - When a portal user creates a new task on the fly from the subtask kanban view, a traceback occurs, and the expected behavior of creating a new task Y in project A is not met. Additionally, task Y should not be a subtask of task T. Solution: - Resolve the traceback issue when creating a new task from the subtask kanban view as a portal user in project sharing. - Ensure that the new task Y is correctly created in project A and is not set as a subtask of task T. task-3584963

- Instead of raising an error, we simply exclude sub-tasks of the current task from the domain of the 'parent task' field task-3584963

xavierbol

LGTM, thanks again for your work. 🙂

xavierbol · 2024-03-28T13:46:40Z

robodoo rebase-ff r+

robodoo · 2024-03-28T13:46:49Z

Merge method set to rebase and fast-forward.

Steps to reproduce: - Access the 'project.task' module. - Create a subtask. - Attempt to save the subtask after adding a project to it. Issue: - Saving a subtask becomes impossible when a project is added, causing an obstruction in the process. Solution: - Rectify the functionality to enable successful saving of a subtask even after adding a project, ensuring a seamless process for subtask creation and association with projects. task-3584963 Part-of: #143282

Steps to reproduce: - In 'project sharing' create a task T in project A. - Add 2 subtasks to task T in project A. - Share project A in edit mode. - Access the view form of task T as a portal user. - Click on the subtask button to navigate to the tree/kanban view of subtasks. - Select the kanban view. - Create a new task on the fly, resulting in a traceback. Issue: - When a portal user creates a new task on the fly from the subtask kanban view, a traceback occurs, and the expected behavior of creating a new task Y in project A is not met. Additionally, task Y should not be a subtask of task T. Solution: - Resolve the traceback issue when creating a new task from the subtask kanban view as a portal user in project sharing. - Ensure that the new task Y is correctly created in project A and is not set as a subtask of task T. task-3584963 Part-of: #143282

Steps to reproduce: - Access the 'project.task' module. - Create a subtask. - Attempt to save the subtask after adding a project to it. Issue: - Saving a subtask becomes impossible when a project is added, causing an obstruction in the process. Solution: - Rectify the functionality to enable successful saving of a subtask even after adding a project, ensuring a seamless process for subtask creation and association with projects. task-3584963 Part-of: odoo#143282

Steps to reproduce: - In 'project sharing' create a task T in project A. - Add 2 subtasks to task T in project A. - Share project A in edit mode. - Access the view form of task T as a portal user. - Click on the subtask button to navigate to the tree/kanban view of subtasks. - Select the kanban view. - Create a new task on the fly, resulting in a traceback. Issue: - When a portal user creates a new task on the fly from the subtask kanban view, a traceback occurs, and the expected behavior of creating a new task Y in project A is not met. Additionally, task Y should not be a subtask of task T. Solution: - Resolve the traceback issue when creating a new task from the subtask kanban view as a portal user in project sharing. - Ensure that the new task Y is correctly created in project A and is not set as a subtask of task T. task-3584963 Part-of: odoo#143282

- Instead of raising an error, we simply exclude sub-tasks of the current task from the domain of the 'parent task' field task-3584963 closes odoo#143282 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

mjvi-odoo requested a review from kais-odoo November 23, 2023 06:42

C3POdoo added the RD research & development, internal work label Nov 23, 2023

kais-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch from af98581 to 78a09de Compare November 28, 2023 04:38

pkyriakou reviewed Dec 8, 2023

View reviewed changes

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch 3 times, most recently from c32d83a to 7bcf49d Compare December 11, 2023 06:11

pkyriakou reviewed Dec 13, 2023

View reviewed changes

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch from 7bcf49d to 9076637 Compare December 13, 2023 10:33

pkyriakou reviewed Dec 20, 2023

View reviewed changes

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch 5 times, most recently from 2ea4f69 to 956bf08 Compare January 5, 2024 07:02

pkyriakou reviewed Jan 5, 2024

View reviewed changes

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch from 956bf08 to 154771f Compare January 8, 2024 07:04

pkyriakou reviewed Jan 11, 2024

View reviewed changes

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch from 154771f to 19d3244 Compare January 11, 2024 17:06

auon-odoo approved these changes Mar 18, 2024

View reviewed changes

xavierbol reviewed Mar 27, 2024

View reviewed changes

mjvi-odoo added 3 commits March 27, 2024 17:53

[FIX] project: add domain in parent_id in convert task/sub-task form

a7c522f

- Instead of raising an error, we simply exclude sub-tasks of the current task from the domain of the 'parent task' field task-3584963

mjvi-odoo force-pushed the 17.0-bug-fixes-project-mjvi branch from 19d3244 to a7c522f Compare March 27, 2024 12:24

xavierbol reviewed Mar 28, 2024

View reviewed changes

xavierbol marked this pull request as ready for review March 28, 2024 13:46

C3POdoo requested a review from a team March 28, 2024 13:58

robodoo closed this in 3dda557 Mar 28, 2024

robodoo temporarily deployed to merge March 28, 2024 16:04 Inactive

This was referenced Mar 28, 2024

[FW][FIX] project: Saving and Task Creation Issues #159731

Closed

[FW][FIX] project: Saving and Task Creation Issues #159758

Closed

[FW][FIX] project: Saving and Task Creation Issues #159776

Closed

xavierbol deleted the 17.0-bug-fixes-project-mjvi branch April 2, 2024 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] project: Saving and Task Creation Issues #143282

[FIX] project: Saving and Task Creation Issues #143282

mjvi-odoo commented Nov 23, 2023 •

edited by kais-odoo

robodoo commented Nov 23, 2023

pkyriakou left a comment

pkyriakou Dec 8, 2023

mjvi-odoo Dec 11, 2023

pkyriakou left a comment

pkyriakou Dec 13, 2023

mjvi-odoo Dec 13, 2023

pkyriakou Dec 13, 2023

mjvi-odoo Dec 13, 2023 •

edited

pkyriakou left a comment

pkyriakou left a comment

pkyriakou Jan 5, 2024

mjvi-odoo Jan 8, 2024

pkyriakou left a comment

pkyriakou Jan 11, 2024

pkyriakou Jan 11, 2024

auon-odoo left a comment

xavierbol Mar 27, 2024

mjvi-odoo Mar 27, 2024

xavierbol left a comment

xavierbol commented Mar 28, 2024

robodoo commented Mar 28, 2024

		<field name="child_ids" invisible="1" />
		<field name="parent_id" domain="[('id', '!=', id),'!', ('id', 'child_of', id)]" context="{'search_default_project_id': project_id, 'search_default_open_tasks': 1}" />

	invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])],'default_project_id': project_id }">
	invisible="not id or subtask_count == 0" context="{'default_user_ids': [(6, 0, [uid])], 'default_project_id': project_id }">

[FIX] project: Saving and Task Creation Issues #143282

[FIX] project: Saving and Task Creation Issues #143282

Conversation

mjvi-odoo commented Nov 23, 2023 • edited by kais-odoo

robodoo commented Nov 23, 2023

pkyriakou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkyriakou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjvi-odoo Dec 13, 2023 • edited

Choose a reason for hiding this comment

pkyriakou left a comment

Choose a reason for hiding this comment

pkyriakou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkyriakou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

auon-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xavierbol left a comment

Choose a reason for hiding this comment

xavierbol commented Mar 28, 2024

robodoo commented Mar 28, 2024

mjvi-odoo commented Nov 23, 2023 •

edited by kais-odoo

mjvi-odoo Dec 13, 2023 •

edited