[FIX] web: fix calendar header buttons' position #144169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edi-odoo
force-pushed
the
17.0-appointment-button-fix-edi
branch
10 times, most recently
from
17c6e8c
to
11f350f
Compare
stefanorigano
requested changes
Dec 12, 2023
edi-odoo
force-pushed
the
17.0-appointment-button-fix-edi
branch
3 times, most recently
from
7d9db36
to
2bff611
Compare
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
3 times, most recently
from
966e52b
to
9e88e34
Compare
mano-odoo
reviewed
Feb 16, 2024
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
2 times, most recently
from
6a8f00b
to
f8c5068
Compare
|
@mano-odoo 👋 |
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
2 times, most recently
from
c55e274
to
f68c3b6
Compare
|
Hey @mano-odoo 👋 The diffs :
|
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
from
f68c3b6
to
17f52b8
Compare
C3POdoo
requested review from
a team,
FrancoisGe and
Iucapad
and removed request for
a team
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
3 times, most recently
from
1146382
to
6615ac3
Compare
|
The branch has been rebased and retargeted to
|
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827
Brieuc-brd
force-pushed
the
17.0-appointment-button-fix-edi
branch
from
6615ac3
to
928107e
Compare
jeh-odoo
approved these changes
Mar 13, 2024
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2024
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827 closes #144169 Related: odoo/enterprise#51755 Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2024
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827 closes #144169 Related: odoo/enterprise#51755 Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2024
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827 closes #144169 Related: odoo/enterprise#51755 Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2024
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827 closes #144169 Related: odoo/enterprise#51755 Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2024
In order to move the "Share availabilities" button between the header and the sidebar toggler on desktop - but also keeping the button on the bottom of the screen on mobile - we've adapted the grid and extended its use to mobile views. By using the grid layout we have more control over scrolling issues and different elements appearing or disappearing in each variant of the calendar view without breaking the layout. task-3617561 part of task-3575827 closes #144169 Related: odoo/enterprise#51755 Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/odoo/enterprise/pull/51755/commits/5a0ae6e0767497dff2f8a2f38bf362998aacc232 we moved the "Share availabilities" button from the control panel to the calendar's header, but we'd like it to come before the
toggleSideBarbutton, so we need to replace the left margin on the button by a right margin on theh5.Requires:
task-3617561
part of task-3575827
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr