[FW][FIX] stock: create picking on mobile #144282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@svs-odoo @Whenrow cherrypicking of pull request #143776 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
svs-odoo
force-pushed
the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
2 times, most recently
from
908350a
to
d6c8621
Compare
|
@Whenrow Something to check: this PR removed the |
svs-odoo
force-pushed
the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
2 times, most recently
from
997cb16
to
9837a96
Compare
svs-odoo
force-pushed
the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
from
9837a96
to
4039e2f
Compare
Before this commit, it was not possible to create a new picking on mobile if this picking has multiple moves. How to reproduce: - Open Odoo on mobile (or on desktop but simulate mobile device with devtools); - Inventory > Operations > Transfers; - Create a new transfer (a receipt for example); - In its operations (moves), add a new product, then add a second product. - Try to save or validate the picking -> A warning prevent to do it, saying you're trying to write on the field `product_qty` instead of the field `product_uom_qty`. What's happening: For a unknown reason, the fields from the `stock.move` list view are saved once a second move is created, even if we're using the kanban view in the mobile version. To avoid this issue, we force the `force_save` to be false for the field `product_qty` in the kanban view. That's way, it prevents the issue. OPW-3577844 X-original-commit: 818e7fc
svs-odoo
force-pushed
the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
from
2325817
to
9b89f4b
Compare
The `stock.move` form view used for the detailed operation is also used when using Odoo on a mobile device and is not usable in such case (for example, the `product_id` is readonly.) To fix this issue, the view is modified this way: - The `product_id` is readonly only if the move has a id or already a move line (that way, the field is editable when creating a new move but is still readonly otherwise); - The `move_line_ids` is readonly until the move's product is set; - The demand qty. and the UoM are editable if the move is draft. Also, some similar mofifications are done to the `stock.move.line` form view too. OPW-3577844
When creating a picking on mobile, the moves are displayed as kanban boxes. But before this commit, only the mvoe's `quantity` is displayed, that means when in draft, the quantity is usually at 0 and it's the demand (`product_uom_qty`) who is relevant. To fix that, display both fields. Also, we display the UoM aswell if the UoM is enabled.
svs-odoo
force-pushed
the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
from
9b89f4b
to
9dcd878
Compare
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jan 29, 2024
Before this commit, it was not possible to create a new picking on mobile if this picking has multiple moves. How to reproduce: - Open Odoo on mobile (or on desktop but simulate mobile device with devtools); - Inventory > Operations > Transfers; - Create a new transfer (a receipt for example); - In its operations (moves), add a new product, then add a second product. - Try to save or validate the picking -> A warning prevent to do it, saying you're trying to write on the field `product_qty` instead of the field `product_uom_qty`. What's happening: For a unknown reason, the fields from the `stock.move` list view are saved once a second move is created, even if we're using the kanban view in the mobile version. To avoid this issue, we force the `force_save` to be false for the field `product_qty` in the kanban view. That's way, it prevents the issue. OPW-3577844 X-original-commit: 818e7fc Part-of: #144282
robodoo
pushed a commit
that referenced
this pull request
Jan 29, 2024
The `stock.move` form view used for the detailed operation is also used when using Odoo on a mobile device and is not usable in such case (for example, the `product_id` is readonly.) To fix this issue, the view is modified this way: - The `product_id` is readonly only if the move has a id or already a move line (that way, the field is editable when creating a new move but is still readonly otherwise); - The `move_line_ids` is readonly until the move's product is set; - The demand qty. and the UoM are editable if the move is draft. Also, some similar mofifications are done to the `stock.move.line` form view too. OPW-3577844 Part-of: #144282
This was referenced Jan 29, 2024
fw-bot
deleted the
17.0-16.0-stock-picking-creation-on-mobile-svs-BBl2-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it was not possible to create a new picking on mobile if this picking has multiple moves.
How to reproduce:
product_qtyinstead of the fieldproduct_uom_qty.What's happening:
For a unknown reason, the fields from the
stock.movelist view are saved once a second move is created, even if we're using the kanban view in the mobile version.To avoid this issue, we force the
force_saveto be false for the fieldproduct_qtyin the kanban view. That's way, it prevents the issue.OPW-3577844
Forward-Port-Of: #143776