[IMP] website: improve configurator logo upload #145047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Guillaume-gdi
force-pushed
the
17.0-improve-configurator-logo-palette-gdi
branch
from
ab06443
to
06830df
Compare
Guillaume-gdi
changed the title
Guillaume-gdi
force-pushed
the
17.0-improve-configurator-logo-palette-gdi
branch
9 times, most recently
from
7ec43f3
to
154f9ba
Compare
Guillaume-gdi
force-pushed
the
17.0-improve-configurator-logo-palette-gdi
branch
2 times, most recently
from
6c67c5e
to
31a06d9
Compare
|
@robodoo delegate=sobo-odoo |
sobo-odoo
requested changes
Dec 19, 2023
addons/website/static/src/client_actions/configurator/configurator.js
Outdated
Show resolved
Hide resolved
addons/website/static/src/client_actions/configurator/configurator.js
Outdated
Show resolved
Hide resolved
addons/website/static/src/client_actions/configurator/configurator.js
Outdated
Show resolved
Hide resolved
addons/website/static/src/client_actions/configurator/configurator.js
Outdated
Show resolved
Hide resolved
Guillaume-gdi
force-pushed
the
17.0-improve-configurator-logo-palette-gdi
branch
8 times, most recently
from
f183862
to
c436795
Compare
sobo-odoo
requested changes
Dec 21, 2023
addons/website/static/src/client_actions/configurator/configurator.js
Outdated
Show resolved
Hide resolved
Before this commit, when a user was uploading a logo for a website via the website configurator, the logo was added as an attachment but the potential previous logo was not deleted. This commit fixes this by deleting the previous logo when a new one is uploaded. Steps to reproduce the issue: - Create a new website - Fill the configurator until you can upload a logo - Upload a logo, then upload another one - Finish the configurator - Edit a page of the website - Change an image => You can see the first logo you uploaded in the list of images. task-3609329
This commit adds a button to remove the website logo in the website configurator. task-3609329
This commit permits to automatically select the colors of the logo after uploading it. task-3609329
Before this commit, when a user uploaded a webp logo through the website configurator, the colors of the logo were not detected. This commit adds the possibility to detect the colors of a webp logo. task-3609329
Guillaume-gdi
force-pushed
the
17.0-improve-configurator-logo-palette-gdi
branch
from
c436795
to
cd0f77c
Compare
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2023
Before this commit, when a user was uploading a logo for a website via the website configurator, the logo was added as an attachment but the potential previous logo was not deleted. This commit fixes this by deleting the previous logo when a new one is uploaded. Steps to reproduce the issue: - Create a new website - Fill the configurator until you can upload a logo - Upload a logo, then upload another one - Finish the configurator - Edit a page of the website - Change an image => You can see the first logo you uploaded in the list of images. task-3609329 Part-of: #145047
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2023
This commit adds a button to remove the website logo in the website configurator. task-3609329 Part-of: #145047
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2023
This commit permits to automatically select the colors of the logo after uploading it. task-3609329 Part-of: #145047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logo detection part of the website configurator.
Summary of changes:
task-3609329