[FIX] Adding user language to context in mail.message message_format method #14589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I confirm the bug but I am not sure about the fix. Also it seems you have not signed the CLA. Regards |
|
Hi,
sorry that i havent sigend the CLA, it was not an intention to forget to sign it, also it was the first time that i did a pull request.
I have debugged the code for round about 2 hours and didn’t find the reason why the context was empty. Because of low time i fixed it this way and did not investigate more time in the reason.
Regards
|
|
Hello, Thanks for the reply. I have investigated and the proper solution was to pass the context earlier. |
mart-e
added a commit
that referenced
this pull request
Dec 6, 2016
The tacked messages in the chatter were parially translated. e.g. "Lead created" The call did not gave the user context and the subtype message was not translated. Closes #14589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Fix the missing localization of chatter message description.
Current behavior before PR:
Create a Lead, look at the chatter, the description is always shown in English (Lead Created)
Desired behavior after PR is merged:
If lang is missing in context the current logged in users language will be added, to localize the message description e.g. instead of "Lead Created" for german users “Interessent angelegt”.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr