[IMP] {google_,microsoft_}calendar: utilize description method #147477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
3 times, most recently
from
e71bbee
to
e9c53ae
Compare
mrsr-odoo
changed the title
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
4 times, most recently
from
85875fb
to
9f07fd1
Compare
| @@ -1361,7 +1361,7 @@ def ics_datetime(idate, allday=False): | |||
|
|
|||
| def _get_customer_description(self): | |||
| """:return (str): The description to include in calendar exports""" | |||
| return html2plaintext(self.description) if self.description else '' | |||
| return self.description if self.description else '' | |||
There was a problem hiding this comment.
Could probably use is_html_emptyby the way
| @@ -298,7 +298,7 @@ def _google_values(self): | |||
| 'start': start, | |||
| 'end': end, | |||
| 'summary': self.name, | |||
| 'description': tools.html_sanitize(self.description) if not tools.is_html_empty(self.description) else '', | |||
| 'description': tools.html_sanitize(self._get_customer_description()) if not tools.is_html_empty(self._get_customer_description()) else '', | |||
There was a problem hiding this comment.
Could be more interesting that _get_customer_description returns a sanitized / validated / Markupized html so that callers don't have to deal with the output and can consider it is safe
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
from
9f07fd1
to
d6e5d79
Compare
|
hello @tde-banana-odoo , |
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
from
d6e5d79
to
a7f5d7e
Compare
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
3 times, most recently
from
f4eed2a
to
c440f82
Compare
mrsr-odoo
changed the title
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
2 times, most recently
from
aa5a27e
to
5c18efb
Compare
This commit does the following- -Makes _get_customer_description to return HTML data. -Replace the description field with _get_customer_description for google_calendar and microsoft_calendar syncs. Task-3458669
mrsr-odoo
force-pushed
the
master-appointment-imp-clarify-description-mrsr
branch
from
5c18efb
to
3f34240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following-
-Makes
_get_customer_descriptionto return HTML data.-Replace the description field with
_get_customer_descriptionfor google_calendar andmicrosoft_calendar syncs.
Task-3458669