[IMP] web_editor: select cells rectangulary on shift + arrowKey #147880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shsa-odoo
reviewed
Jan 3, 2024
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
shsa-odoo
reviewed
Jan 4, 2024
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
shsa-odoo
reviewed
Jan 4, 2024
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
from
c34d6dc
to
86861cf
Compare
|
@shsa-odoo Done required changes! |
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
2 times, most recently
from
e63e786
to
4d790b2
Compare
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
2 times, most recently
from
375dfb0
to
5d39025
Compare
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
2 times, most recently
from
c1b29fd
to
44f1b46
Compare
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
3 times, most recently
from
486b827
to
e96c3b9
Compare
deso-odoo
reviewed
Apr 3, 2024
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/utils/utils.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
deso-odoo
reviewed
Apr 4, 2024
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
deso-odoo
reviewed
Apr 8, 2024
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js
Outdated
Show resolved
Hide resolved
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
from
e96c3b9
to
8109e7d
Compare
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
from
8109e7d
to
1898225
Compare
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
from
1898225
to
40f3b0c
Compare
deso-odoo
reviewed
May 13, 2024
addons/web_editor/static/src/js/editor/odoo-editor/test/spec/editor.test.js
Outdated
Show resolved
Hide resolved
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
2 times, most recently
from
76bda2f
to
9998e7b
Compare
Current behaviour before commit: In table, when pressing shift + any arrow key, cells are selected irregularly and not rectangularly. Desired behaviour after commit: -This commit improves the behaviour of cell selection through keyboad in more convenient (symmetrical) way. -When there is one or more cells are selected, pressing shift + any arrow key expends or shrinks cell-selection rectangularly relative to the arrow key directions. task-3442805
Current behaviour before commit: Can't select a single cell using keyboard when there is selection inside a single cell. Desired behaviour after commit: -If there is no content in a cell, pressing shift + ArrowKey selects single cell. -If there is content in a cell, pressing shift + ArrowKey selects the content of cell as per browser's default behaviour. Once selection is at the edge if the content the cell gets selected. -If there are two selected cells, pressing shift + ArrowKey to shrink the selection selects single cell.
Current behaviour before commit: -When there is a text above and below a table and user starts selecting the content from the text above the table using keyboard, he needs to press shift + ArrowDown multiple times to reach the text below table. -Similar scenario occurs in case of selecting from text below to the text above. -This happens because when selection is inside the table as well as outside of it, table gets fully selected through customized selection but the actual focusNode is still the first cell of the table. Desired behaviour after commit: Now when selection enters the table from outside, last cell of the table cell is set as focusNode (fisrst cell in case of inverse selection) in order to select the full table. Due to this, user can select the content after the table in just one press. task-3442805
Before this commit When a table is fully selected along with content outside of it, user needs to hit shift + ArrowKey multiple times to deselect the table, it gets deselected at once at the end. This commit ensures that user can deselect the table in a single try. task-3442805
adsa-odoo
force-pushed
the
master-table-selection-imp-adsa
branch
from
9998e7b
to
6196a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour before PR:
selected irregularly and not rectangularly.
Desired behaviour after PR:
This PR aims to improve the behaviour of cell selection
through keyboad in more convenient (symmetrical) way.
When there is one or more cells are selected, pressing
shift + any arrow key expends or shrinks cell-selection
rectangularly relative to the arrow key directions.
It also improves the behaviour of selecting and deselecting
multiple tables.
task-3442805
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr