[FIX] base: set parent company only once #147912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AH-Yussef
force-pushed
the
17.0-opw-3660943-set_parent_company_only_once-alhy
branch
3 times, most recently
from
f64a1f1
to
3e0ded8
Compare
nle-odoo
approved these changes
Jan 4, 2024
AH-Yussef
force-pushed
the
17.0-opw-3660943-set_parent_company_only_once-alhy
branch
from
3e0ded8
to
4ac5490
Compare
Steps to reproduce: - Go to Settings > Users & Companies > Companies - Create a new company called Child Company - Create a new company called Parent Company - Go to the Child Company - In Gneral Information tab, set the Parent Company property to Paretn Company - An Error is raised stating that "The company hierarchy cannot be changed." Investigation: The following commit odoo@b5d0001 changed the behavior to prevent changing/updating the company hierarchy -Parent > Child- with https://github.com/odoo/odoo/blob/a0741f6427514be5246a5476b5c2f1ca1c23e6e5/odoo/addons/base/models/res_company.py#L297-L298 opw-3660943
AH-Yussef
force-pushed
the
17.0-opw-3660943-set_parent_company_only_once-alhy
branch
from
4ac5490
to
275a1d5
Compare
C3POdoo
requested review from
a team,
xmo-odoo and
rco-odoo
and removed request for
a team
rco-odoo
requested changes
Jan 16, 2024
There was a problem hiding this comment.
That does not look good to me. You have to think about the potential consequences.
There was a good reason for not changing the hierarchy. Assume you create both root companies A and B, like in your scenario. Then you instantiate a chart of accounts for each company. Then you make company B become a child of company A. And boom! you just fucked up the accounting, because the new accounting rules state that company B must use company A's chart of accounts. @william-andre can you confirm my claim?
IMO the right way to create the companies is:
- create the parent company first,
- create the child company with the right parent.
|
Yes. Changing the parent_id in any case is very likely to break things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Investigation:
The following commit b5d0001 changed the behavior to prevent changing/updating the company hierarchy -Parent > Child- with
odoo/odoo/addons/base/models/res_company.py
Lines 297 to 298 in a0741f6
opw-3660943