[FW][FIX] web: add autocomplete attribute to the email input in login view #147979
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: In chrome, you can see the message "[DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq)". After: The message does not appear. Also, This maintains consistency with the password input which has the attribute autocomplete. X-original-commit: df53b6a
|
@rolandojduartem @FrancoisGe this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 4, 2024
Before: In chrome, you can see the message "[DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq)". After: The message does not appear. Also, This maintains consistency with the password input which has the attribute autocomplete. closes #147979 X-original-commit: df53b6a Signed-off-by: Francois Georis (fge) <fge@odoo.com>
|
@rolandojduartem @FrancoisGe staging failed: ci/runbot on e9c0aa5676ff9561111b7054708438d653eff14f (view more at https://runbot.odoo.com/runbot/build/55935261) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
In chrome, you can see the message "[DOM] Input elements should have autocomplete attributes (suggested: "username"):
(More info: https://goo.gl/9p2vKq)".
After:
The message does not appear.
Also, This maintains consistency with the password input which has the attribute autocomplete.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #146934
Forward-Port-Of: #146037