[FIX] mail: templates preview wrong recipients

[ande-odoo]

Steps to reproduce:

1. Activate dev mode
2. Go to Email Templates
3. Create a new template
4. Applies to Task
5. Email Configuration > To (Partners)
6. {{[p.id for p in object.message_partner_ids]}}
7. Click on Preview
8. Select a record with followers
9. Look at Recipients
10. => No or not all followers/partners are included

Cause of the issue:

Caused by cf7ae6b
In the case of partner_to being '[2,3,4]'
Split would output '[2', '3', '4]'
So after the isdigit it would be '3'
It should have been 2, 3, 4

opw-3677069

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

Pull request status dashboard.

[ande-odoo]

Alternative solution would be to use re.findall(r'\d+', partner_to)

[tde-banana-odoo]

Actually partner_to should be a list of partner ids (comma separated list of ids). It is not meant to be used with records, it is not a m2m field, as help on field tells: help="Comma-separated ids of recipient partners"

[tde-banana-odoo]

The real fix is to use ','.join(p.id for p in message.partner_ids).

[nle-odoo]

thanks

so this is not an issue and there should be in step 6, eg. {{str(object.message_partner_ids.ids)[1:-1]}} or {{','.join(str(p.id) for p in object.message_partner_ids)}}

[tde-banana-odoo]

Indeed. Note that we could try to support a stringified list in addition to a comma separated list of ids for that kind of use case, aka considering [1, 2, 3] is as valid as 1, 2, 3 . It would be more defensive (and can be done here while we are at it).

[ande-odoo]

@tde-banana-odoo Done + modified commit message

[ande-odoo]

Hi @tde-banana-odoo
Concerning the runbot test error, since I'm using literal_eval, input like 2131,2132,0,test would raise a UserError.
How do you think I should approach the issue ? By fixing the test or finding another way of doing _parse_partner_to ?

[tde-banana-odoo]

2131,2132,0,test does not seem like a valid input, so not sure what you mean ?

[ande-odoo]

@tde-banana-odoo I added the fallback to the previous version of the function as requested, what do you think ?

[tde-banana-odoo]

Zboing, looked at it again, small improvement proposal + some lint on tests :)

[ande-odoo]

Hi @tde-banana-odoo I updated the code with the best of both worlds, and modified the test, tell me what you think !

[tde-banana-odoo]

@robodoo r+

Thanks :)