[FIX] discuss: fix slider values in call settings #151028

ThanhDodeurOdoo · 2024-01-25T09:17:34Z

Adds text values for the call settings sliders.
Replaces onChange events with onInput events so that the values
respect the position of the sliders.
Debounces some functions to handle the increased amount of calls
due to the swap to the onInput listener.
Changes the default value of voiceActiveDuration from 0 to 200
to match the minimum value of the input.

robodoo · 2024-01-25T09:18:11Z

ThanhDodeurOdoo · 2024-01-25T10:06:37Z

zel-odoo · 2024-01-25T10:10:38Z

cc @zel-odoo

thanks for reminding me. is this going to be done in 17.0 soon? I can wait for rebase either make the change in master in my PR if it is gonna merged soon.

ThanhDodeurOdoo · 2024-01-25T10:20:18Z

@zel-odoo since you are removing the file and moving the code, you may just do the changes to your new file (not sure if rebase will be smart enough), but wait that the PR is reviewed, more values display may be added.

zel-odoo · 2024-01-25T10:23:00Z

@ThanhDodeurOdoo OK, then I will directly change the code according to your change.

addons/mail/static/src/discuss/call/common/call_settings.xml

phenix-factory · 2024-01-30T12:38:50Z

@ThanhDodeurOdoo You have a bunch of sliders and @zel-odoo is also adding a bunch of them based on yours. Maybe this could be a Slider component generic component?

zel-odoo · 2024-01-30T12:41:08Z

@ThanhDodeurOdoo You have a bunch of sliders and @zel-odoo is also adding a bunch of them based on yours. Maybe this could be a Slider component generic component?

Something like this

ThanhDodeurOdoo · 2024-01-30T13:10:10Z

@phenix-factory yes that's probably the goal for master, we will need it when doing the slider with visual feedback for the voice threshold

seb-odoo

@robodoo r+

zel-odoo · 2024-02-01T10:58:47Z

addons/mail/static/src/discuss/call/common/call_settings.xml

-                                <input class="flex-grow-2 form-range" type="range" min="0" max="20" step="1" t-att-value="userSettings.edgeBlurAmount" t-on-change="onChangeEdgeBlurAmount"/>
+                            <div class="d-flex w-100 align-items-center">
+                                <input class="flex-grow-2 form-range" type="range" min="0" max="20" step="1" t-att-value="userSettings.edgeBlurAmount" t-on-input="onChangeEdgeBlurAmount"/>
+                                <span class="p-1 w-50 text-end"><t t-out="Math.floor(userSettings.edgeBlurAmount * 5)"/>%</span>


i would suggest using width: 6ch in .scss files. means three digits + % and ` character for buffering... 25% width is way too much and it is displaying well in my PR

@zel-odoo yes it felt a bit too big, but not enough to make me want to create a new scss file just for that in a fix, if you have more finely tuned dimensions in your PR for master, i think that it's good

OK, then I will have it at my PR

zel-odoo · 2024-03-27T14:29:53Z

do we still want to have this PR? Should I apply those changes into mine ( configuration menu) ?

ThanhDodeurOdoo · 2024-03-27T15:49:27Z

@zel-odoo I will rebase it, I thought it was merged

* Adds text values for the call settings sliders. * Replaces `onChange` events with `onInput` events so that the values respect the position of the sliders. * Debounces some functions to handle the increased amount of calls due to the swap to the `onInput` listener. * Changes the default value of `voiceActiveDuration` from `0` to `200` to match the minimum value of the input.

seb-odoo

@robodoo r+ delegate+

fw-bot · 2024-04-01T05:54:15Z