-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] stock: fix text product label reports with special characters #151859
[FIX] stock: fix text product label reports with special characters #151859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
the report is intended to be of qweb-text type and we should not escape text as if rendered in html
@odoo/rd-security |
@xmo-odoo sorry my message got lost. I'll need an excepetion for the security ci. I added a |
@robinengels is there no risk of that being an issue for the barcode or default_code? @robodoo override=ci/security text rendering, so we specifically need to bypass HTML escaping |
@xmo-odoo barcode should be only numbers so it shouldn't be an issue. But if someone ever comes up with a use case where they need special characters in the barcode we can change it yes. |
@robodoo retry |
I'm sorry, @robinengels: retry makes no sense when the PR is not in error. |
@odoo/rd-logistics can you have a look at this ? Thanks |
@robinengels seems ok to me, but wouldn't the same problem happen for Also why are you targeting 17.0? Shouldn't it be for 15.0? Especially since the customer on that ticket is using saas-16.3? |
Current behavior: When printing products ZPL Labels, special characters are not printed correctly. e.g. quotes become ' Steps to reproduce: - Modify a product name with special characters - Print a product label - Select ZPL Labels As the report is only rendered as text, the special characters are not dangerous and can be printed as is. opw-3684870
ddc6ed5
to
b35cbdf
Compare
Current behavior:
When printing products ZPL Labels, special characters are not printed correctly. e.g. quotes become '
Steps to reproduce:
opw-3684870
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr