-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] l10n_it_edi: Codes in XML template shouldn't be translated #153111
[FIX] l10n_it_edi: Codes in XML template shouldn't be translated #153111
Conversation
|
d2c54f3
to
d5a295c
Compare
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were translated. They shouldn't be, as they have pretty short char limit and it's risky to people change that. The XML users are either domestic or the Italian Tax Agency itself, so no point in translating "Divisa" into "Currency" anyway. Link: https://www.odoo.com/web#model=project.task&id=3627379 opw-3627379
d5a295c
to
d5c6fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Just a little comment.
Also your solution (not translate it all) is not the same as the solution the PO propose (translate with max length), I guess it was discussed with him and he is aware of it ?
LGTM @rugo-odoo |
(cc @william-andre) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were translated. They shouldn't be, as they have pretty short char limit and it's risky to people change that. The XML users are either domestic or the Italian Tax Agency itself, so no point in translating "Divisa" into "Currency" anyway. Link: https://www.odoo.com/web#model=project.task&id=3627379 opw-3627379 closes #153111 Signed-off-by: William André (wan) <wan@odoo.com>
@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed): |
@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed): |
@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed): |
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were translated. They shouldn't be, as they have pretty short char limit and it's risky to people change that. The XML users are either domestic or the Italian Tax Agency itself, so no point in translating "Divisa" into "Currency" anyway. Link: https://www.odoo.com/web#model=project.task&id=3627379 opw-3627379 closes odoo/odoo#153111 Signed-off-by: William André (wan) <wan@odoo.com>
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were translated.
They shouldn't be, as they have pretty short char limit and it's risky to people change that. The XML users are either domestic or the Italian Tax Agency itself, so no point in translating "Divisa" into "Currency" anyway.
Link: https://www.odoo.com/web#model=project.task&id=3627379
opw-3627379