Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_it_edi: Codes in XML template shouldn't be translated #153111

Closed

Conversation

lordkrandel
Copy link
Contributor

@lordkrandel lordkrandel commented Feb 7, 2024

Codes like "Exch.Rate" in the Italian EDI XML template for invoices were translated.
They shouldn't be, as they have pretty short char limit and it's risky to people change that. The XML users are either domestic or the Italian Tax Agency itself, so no point in translating "Divisa" into "Currency" anyway.

Link: https://www.odoo.com/web#model=project.task&id=3627379
opw-3627379

@robodoo
Copy link
Contributor

robodoo commented Feb 7, 2024

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Feb 7, 2024
@lordkrandel
Copy link
Contributor Author

lordkrandel commented Feb 7, 2024

@jco-odoo - Yet I don't understand why these tags in the template are in English and get translated. They shouldn't be language dependent.

@lordkrandel lordkrandel force-pushed the 16.0-l10n-it-edi-translation-fix-pgi branch from d2c54f3 to d5a295c Compare February 22, 2024 16:46
@lordkrandel lordkrandel changed the title [FIX] l10n_it_edi: Translation of an XML field was exceeding max length [FIX] l10n_it_edi: Codes in XML template shouldn't be translated Feb 22, 2024
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were
translated. They shouldn't be, as they have pretty short char limit and
it's risky to people change that. The XML users are either domestic or
the Italian Tax Agency itself, so no point in translating "Divisa" into
"Currency" anyway.

Link: https://www.odoo.com/web#model=project.task&id=3627379
opw-3627379
@lordkrandel lordkrandel force-pushed the 16.0-l10n-it-edi-translation-fix-pgi branch from d5a295c to d5c6fb9 Compare February 22, 2024 16:53
@lordkrandel lordkrandel requested review from a team and rugo-odoo and removed request for jco-odoo and a team February 22, 2024 16:53
Copy link
Contributor

@rugo-odoo rugo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Just a little comment.

Also your solution (not translate it all) is not the same as the solution the PO propose (translate with max length), I guess it was discussed with him and he is aware of it ?

@tsb-odoo
Copy link
Contributor

LGTM @rugo-odoo

@rugo-odoo
Copy link
Contributor

(cc @william-andre)

Copy link
Contributor

@william-andre william-andre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Mar 1, 2024
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were
translated. They shouldn't be, as they have pretty short char limit and
it's risky to people change that. The XML users are either domestic or
the Italian Tax Agency itself, so no point in translating "Divisa" into
"Currency" anyway.

Link: https://www.odoo.com/web#model=project.task&id=3627379
opw-3627379

closes #153111

Signed-off-by: William André (wan) <wan@odoo.com>
@robodoo robodoo closed this Mar 1, 2024
@fw-bot
Copy link
Contributor

fw-bot commented Mar 5, 2024

@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Contributor

fw-bot commented Mar 6, 2024

@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Mar 7, 2024

@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Mar 8, 2024

@lordkrandel @william-andre this pull request has forward-port PRs awaiting action (not merged or closed):

gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 9, 2024
Codes like "Exch.Rate" in the Italian EDI XML template for invoices were
translated. They shouldn't be, as they have pretty short char limit and
it's risky to people change that. The XML users are either domestic or
the Italian Tax Agency itself, so no point in translating "Divisa" into
"Currency" anyway.

Link: https://www.odoo.com/web#model=project.task&id=3627379
opw-3627379

closes odoo/odoo#153111

Signed-off-by: William André (wan) <wan@odoo.com>
@fw-bot fw-bot deleted the 16.0-l10n-it-edi-translation-fix-pgi branch March 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants