Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock: automated transfer creation for exchange of returns #153184

Conversation

jipr-odoo
Copy link
Contributor

@jipr-odoo jipr-odoo commented Feb 8, 2024

Before this commit:

There were no transfers for exchange of return, Users were required to create transfers for return exchanges manually (return of return).

After this commit:

  • Implemented a 'Return for Exchange' button, enabling automated transfer
    creation for exchange of return."
  • Rename method name create_returns to action_create_returns.

task-3543473

Enterprise PR: odoo/enterprise#59424

@robodoo
Copy link
Contributor

robodoo commented Feb 8, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Feb 8, 2024
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch 2 times, most recently from a09ec08 to 87ad208 Compare March 26, 2024 11:00
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch from 87ad208 to 67820eb Compare April 10, 2024 07:11
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch 3 times, most recently from 640d84a to c63395d Compare May 3, 2024 09:08
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch 4 times, most recently from b88f7a6 to f5677c7 Compare May 15, 2024 04:34
@svs-odoo svs-odoo marked this pull request as ready for review May 16, 2024 06:37
@C3POdoo C3POdoo requested a review from a team May 16, 2024 06:39
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch 2 times, most recently from 70c473d to 84079ef Compare May 16, 2024 12:30
@svs-odoo svs-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch from 84079ef to 98f99b7 Compare May 22, 2024 11:31
@svs-odoo svs-odoo changed the title [FIX] stock: automated transfer creation for exchange of returns [IMP] stock: automated transfer creation for exchange of returns May 22, 2024
@svs-odoo svs-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch from 98f99b7 to 086d65e Compare May 22, 2024 11:52
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch from 086d65e to cbdb081 Compare May 23, 2024 11:07
@svs-odoo
Copy link
Contributor

robodoo r+

robodoo pushed a commit that referenced this pull request May 27, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
robodoo pushed a commit that referenced this pull request May 27, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
robodoo pushed a commit that referenced this pull request May 27, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
robodoo pushed a commit that referenced this pull request May 27, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
@d-fence
Copy link
Contributor

d-fence commented May 27, 2024

Sorry I had to unreview because of too many staging failures.
It seem that your branch is not up to date enough and does not contains afdf4e1. That's why it was not detected during runbot builds.

@robodoo
Copy link
Contributor

robodoo commented May 27, 2024

@jipr-odoo @svs-odoo linked pull request(s) odoo/enterprise#59424 not ready. Linked PRs are not staged until all of them are ready.

*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473
@jipr-odoo jipr-odoo force-pushed the master-stock-automated-exchange-return-fix-jipr branch from cbdb081 to 14b7d99 Compare May 28, 2024 05:04
@jipr-odoo jipr-odoo requested a review from svs-odoo May 28, 2024 06:31
@jipr-odoo
Copy link
Contributor Author

@svs-odoo can you please check again?

@svs-odoo
Copy link
Contributor

robodoo r+

robodoo pushed a commit that referenced this pull request May 28, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
robodoo pushed a commit that referenced this pull request May 28, 2024
*: mrp_subcontracting, purchase_mrp, purchase_stock, repair, sale_mrp,
sale_stock, stock_account, stock_delivery, stock_dropshipping

This commit adds a new action for the `stock.return.picking` wizard,
`action_create_exchanges`, to be able to create automatically a transfer
for exchange (basically a return of a return.)
A "Return for Exchange" button was added in the wizard form view.

Beside of that, some cleaning was done:
- Rename method name `create_returns` to `action_create_returns`;
- `_create_return` returns the created picking instead of a tuple with
  the picking id and its picking type id;
- Calls super without arguments when not needed, uses new `Command` of
  old ones, and other mino changes like this.

task-3543473

closes #153184

Related: odoo/enterprise#59424
Signed-off-by: Steve Van Essche <svs@odoo.com>
@robodoo robodoo added the 17.3 label May 28, 2024
@robodoo robodoo closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants