Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n_rw: basic package #153501

Closed

Conversation

malb-odoo
Copy link
Contributor

@malb-odoo malb-odoo commented Feb 9, 2024

Add the basic package to the Rwanda localisation.

-COA
-Taxes
-Default settings
-Tax report
-Fiscal position

task-3584127


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Feb 9, 2024

@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch from e31e0e0 to ab7be00 Compare February 9, 2024 15:55
@C3POdoo C3POdoo added the RD research & development, internal work label Feb 9, 2024
@malb-odoo
Copy link
Contributor Author

The translation are not there because the legal document in rwanda seems to be in english

@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch 2 times, most recently from 76c418c to b256e19 Compare February 26, 2024 08:32
@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch from b256e19 to 562193c Compare March 7, 2024 15:39
"rw_191","191","Accounts, Notes And Loans Receivable","asset_receivable","True"
"rw_192","192","Contracts","asset_current","False"
"rw_193","193","Nontrade And Other Receivables","asset_receivable","True"
"rw_195","195","Cash","asset_cash","False"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this account, it will be a duplicate of the one added by the template

@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch 2 times, most recently from 4dc9ae1 to 523a0a9 Compare March 20, 2024 15:44
@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch from 523a0a9 to 6871bf3 Compare March 25, 2024 08:47
@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch 2 times, most recently from 2943c7f to a92373a Compare April 3, 2024 12:43
@malb-odoo malb-odoo marked this pull request as ready for review April 3, 2024 13:17
@malb-odoo malb-odoo requested review from a team and dbkosky and removed request for a team April 3, 2024 13:18
Copy link
Contributor

@dbkosky dbkosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task-id in the commit message is for Malta at the moment, you might want to change it to 3584127

'version': '1.0',
'depends': [
'account',
'base_vat',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is base_vat required? I don't see anything in base_vat that is useful for Rwanda at the moment,

If you're interested in adding VAT validation for Rwanda too, I don't see any support in stdnum 1.17, so you'd need to add a custom check_vat_rw function inside of odoo/addons/base_vat/models/res_partner.py,

otherwise we can remove this dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it, it's a wrong copy paste from another loca, nice catch !

"id","name","sequence","auto_apply","vat_required","country_id","country_group_id","tax_ids/tax_src_id","tax_ids/tax_dest_id"
"fiscal_position_rw_exempt","Exempt taxpayer","1","","","","","VAT_S_IN_RW_18","VAT_S_exempt_O"
"","","","","","","","VAT_S_IN_O","VAT_S_exempt_O"
"","","","","","","","VAT_P_IN_RW_18","VAT_P_IN_RW_0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this case, why would we map from 18% to 0% when the seller is exempted, does it not depend on the buyer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided with laura to remove the fiscal position 😄 Thanks !

@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch from a92373a to 1cb4b98 Compare April 12, 2024 12:13
@@ -0,0 +1,4 @@
"id","name","sequence","auto_apply","vat_required","country_id","country_group_id","tax_ids/tax_src_id","tax_ids/tax_dest_id"
"fiscal_position_rw_national","National B2B","2","1","1","base.rw","","",""
"fiscal_position_rw_international","International","3","","","","","VAT_S_IN_RW_18","VAT_S_EXPORT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed while testing this in combination with the enterprise branch, that this fiscal position is not automatically applied.
In my experience the "international" is usually automatically applied.. is it part of the spec that it isn't automatically applied in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to put the auto apply, nice catch !

Add the basic package to the Rwanda localisation.

-COA
-Taxes
-Default settings
-Tax report
-Fiscal position

task-3584127
@malb-odoo malb-odoo force-pushed the 17.0-l10n_rw-basic-package-malb branch from 1cb4b98 to 3a9c374 Compare April 19, 2024 07:31
Copy link
Contributor

@FlorianGilbert FlorianGilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo robodoo closed this in aec2529 Apr 26, 2024
willylohws pushed a commit to willylohws/odoo that referenced this pull request May 1, 2024
Add the basic package to the Rwanda localisation.

-COA
-Taxes
-Default settings
-Tax report
-Fiscal position

task-3584127

closes odoo#153501

Related: odoo/enterprise#57099
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
@fw-bot fw-bot deleted the 17.0-l10n_rw-basic-package-malb branch May 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants