[IMP] web: throwing an exception when comparison wrong datatypes #153595
Conversation
mega-odoo
force-pushed
the
master-compare-wrong-datatypes-mega
branch
2 times, most recently
from
dc8d540
to
028dacf
Compare
mega-odoo
force-pushed
the
master-compare-wrong-datatypes-mega
branch
6 times, most recently
from
4671ca0
to
2d0be61
Compare
| expect(evaluateExpr("'foo' < 4444")).toBe(false); | ||
| expect(evaluateExpr("{} < []")).toBe(true); | ||
| expect(evaluateExpr('0 < "2024-02-09"')).toBe(true); | ||
| expect(evaluateExpr('"2024-02-09" > 0')).toBe(true); |
There was a problem hiding this comment.
From what I see, the purpose of the pr is to make an error when the types are different.
In this case, why make a new special case with the dates?
| @@ -96,7 +102,14 @@ function isLess(left, right) { | |||
| if (leftIndex === rightIndex) { | |||
| return left < right; | |||
| } | |||
| return leftIndex < rightIndex; | |||
| if ((left == 0 && rightIndex == 4) || (leftIndex == 4 && right == 0)) { | |||
There was a problem hiding this comment.
Why make a new special case with the dates and 0 ?
There was a problem hiding this comment.
In certain scenarios, when comparing two date fields and one of them is empty, At that point system treats it as a "false" value. Consequently, there arises a need to handle comparisons between a "false" value and a valid date value.
There was a problem hiding this comment.
@Gorash I think we should cancel this task. I didn't anticipate the date cornercase, but now that I'm aware of it, I think it's better to keep the behavior as it is right now. 0 < "2022-10-10" isn't a valid python expression, but we must support it. So those aren't really python expressions, I rather see them as a derived DSL. We should keep it as simple as possible, and this PR adds complexity.
mega-odoo
force-pushed
the
master-compare-wrong-datatypes-mega
branch
from
2d0be61
to
b40fa67
Compare
Before this commit When comparing values of different data types in an XML expression,The expression would return a value instead of throwing an exception. After this commit If a developer mistakenly compares values of different data types in an XML expression, An exception will be thrown. Task-3600595
mega-odoo
force-pushed
the
master-compare-wrong-datatypes-mega
branch
from
b40fa67
to
f63d221
Compare
C3POdoo
requested review from
a team,
aab-odoo and
BastienFafchamps
and removed request for
a team
| * @param {any} val | ||
| * @returns {boolean} boolean type | ||
| */ | ||
| function is_date(val) { |
|
Cancelling the task/closing the PR. See #153595 (comment) for reason. |
|
Sorry for the inconvenience @mega-odoo @maan-odoo @bit-odoo |
Before this commit
When comparing values of different data types in an XML expression,The expression would return a value instead of throwing an exception.
After this commit
If a developer mistakenly compares values of different data types in an XML expression, An exception will be thrown.
Task - 3600595
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr