Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] hr_skills: Page name already exist #154761

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 20, 2024

Description of the issue/feature this PR addresses:
When hr_skills is installed we have 2 tabs/page with the same name in xml (Work Information and Resume). As "Work Information" is defined in hr modules hr_skills must be updated.
image

  • In employee form
  • Open studio
  • Click on "Work Information" tab/page
  • Remove "Work Information" tab/page view

Current behavior before PR:

  • Traceback due to invalid xpath expression (or error depending of version and/or module installed
  • Invalid xpath due to duplicated name for a node

Desired behavior after PR is merged:

  • Tab is removed without traceback

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #154731

Steps:
- In employee form
- Open studio
- Remove "Work Information" tab

Actual result:
- Traceback due to invalid xpath expression
- Invalid xpath due to duplicated name for a node

Expected result
- Tab is removed without traceback

opw-3754375

odoo/odoo@8e14972

X-original-commit: a566d41
@robodoo
Copy link
Contributor

robodoo commented Feb 20, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 20, 2024

This PR targets saas-15.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Feb 20, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 20, 2024

@GaetanVandenBergh @sofiagvaladze the next pull request (#154776) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Feb 20, 2024
@GaetanVandenBergh
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Feb 29, 2024
Steps:
- In employee form
- Open studio
- Remove "Work Information" tab

Actual result:
- Traceback due to invalid xpath expression
- Invalid xpath due to duplicated name for a node

Expected result
- Tab is removed without traceback

opw-3754375

8e14972

closes #154761

X-original-commit: a566d41
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Gaetan Vanden Bergh (gavb) <gavb@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Feb 29, 2024

@GaetanVandenBergh @sofiagvaladze staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/59014846)

@GaetanVandenBergh
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Feb 29, 2024
Steps:
- In employee form
- Open studio
- Remove "Work Information" tab

Actual result:
- Traceback due to invalid xpath expression
- Invalid xpath due to duplicated name for a node

Expected result
- Tab is removed without traceback

opw-3754375

8e14972

closes #154761

X-original-commit: a566d41
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Gaetan Vanden Bergh (gavb) <gavb@odoo.com>
@robodoo robodoo closed this Feb 29, 2024
@fw-bot fw-bot deleted the saas-15.2-15.0-hr_skills-page-name-already-used-gavb-VF6q-fw branch March 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants