-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] l10n_in, l10n_in_edi: display alert message on absence of PAN #155202
base: 17.0
Are you sure you want to change the base?
[IMP] l10n_in, l10n_in_edi: display alert message on absence of PAN #155202
Conversation
Hello 👋🏻
|
c393bf6
to
1b88a7a
Compare
Hello @lordkrandel , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
1b88a7a
to
8b3df01
Compare
Hello @lordkrandel , |
Hello @lordkrandel , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qdp-odoo for final review.
8b3df01
to
8bfe416
Compare
8bfe416
to
b9f68a8
Compare
Hello @qdp-odoo , |
<field name="display_null_pan_warning" invisible="1"/> | ||
<div class="alert alert-warning main mb-0" role="alert" | ||
invisible="not display_null_pan_warning"> | ||
If the partner has no PAN Number, please apply TDS / TCS at a higher rate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lack of alert may result in non-compliance with the Income Tax Act, causing practical difficulties for users and attracting penal consequences.
Shouldn't it be a hard constraint instead of a warning then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @william-andre
To put a constraint, we have to set a higher rate for each TDS/TCS section. But since there's no place on the tax form for the system to check these rates, we can't put constraint.
Also, there are exceptions, like payments to non-residents who might not have PAN. In these cases, charging TDS/TCS at a higher rate isn't necessary even without PAN. So, if we make a rule, it might stop the process. Instead, we're just issuing a warning without making any firm rules.
"tax_tag_base_tds","BASE TDS","taxes" | ||
"tax_tag_base_tcs","BASE TCS","taxes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We display a message when those tags are used.
So these tags mean "low rates", whatever that means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We display a message when those tags are used. So these tags mean "low rates", whatever that means?
No, it doesn't mean low rate, it's just mean that TDS/TCS is applicable on this transaction at higher rate, as we don't have a field on taxes to define higher rate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use the tags to say that there is something with higher rates then?
Or the xmlids in stable and a field in master?
Or something else?
I just think that this warning is going to be confusing more than anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use the tags to say that there is something with higher rates then? Or the xmlids in stable and a field in master? Or something else?
I just think that this warning is going to be confusing more than anything.
Thank you for the idea. I think it's a good one, so we're updating the plan. Now we'll have tags: "High TDS" and "High TCS". We'll use these tags when the TDS/TCS rates are high. If either of those two tags is present and PAN isn't there, the system won't show an alert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make more sense to know which are not the highest rates, so that you know exactly when to have a warning/error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make more sense to know which are not the highest rates, so that you know exactly when to have a warning/error?
Yes, it makes sense. That's why we labeled regular rates as "BASE TDS" and "BASE TCS" and higher rates as "HIGH TDS" and "HIGH TCS."
Additionally, we're going to include these four labels in the new TDS report/spreadsheet we're making because the current one doesn't show the base amount.
c347475
to
6869f48
Compare
Under Section 206AA/206AB of the Income Tax Act, 1961, if the PAN of a Vendor/Customer is unavailable, TDS/TCS should be at a higher rate. With this commit, whenever a user applies TDS/TCS and the PAN number is absence of a partner, they will get an alert message to apply TDS/TCS at a higher rate. Task-3707451
6869f48
to
6db2423
Compare
Hello @william-andre , |
Under Section 206AA/206AB of the Income Tax Act, 1961, if the PAN of a Vendor/Customer is unavailable, TDS/TCS should be at a higher rate.
With this PR, whenever a user applies TDS/TCS and the PAN number is absence of a partner, they will get an alert message to apply TDS/TCS at a higher rate.
Link: https://www.odoo.com/web#model=project.task&id=3707451
Task-3707451