Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_in, l10n_in_edi: display alert message on absence of PAN #155202

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

jasa-odoo
Copy link
Contributor

@jasa-odoo jasa-odoo commented Feb 23, 2024

Under Section 206AA/206AB of the Income Tax Act, 1961, if the PAN of a Vendor/Customer is unavailable, TDS/TCS should be at a higher rate.

With this PR, whenever a user applies TDS/TCS and the PAN number is absence of a partner, they will get an alert message to apply TDS/TCS at a higher rate.

Link: https://www.odoo.com/web#model=project.task&id=3707451
Task-3707451

@robodoo
Copy link
Contributor

robodoo commented Feb 23, 2024

@C3POdoo C3POdoo requested review from a team and lordkrandel and removed request for a team February 23, 2024 12:26
@C3POdoo C3POdoo added the RD research & development, internal work label Feb 23, 2024
@lordkrandel
Copy link
Contributor

Hello 👋🏻

  • I notice that this is an IMProvement and it's done in saas-16.2 so you might want to do it in 16.0 or 17.0 if it's a law requirement (stable policy), as this current version is not open to the public anymore.

  • I see this task is still in RD dev, so I remove myself from review for now, you're free to re-request my review when the development done and hopefully a PO has tested and validated it.

@lordkrandel lordkrandel removed their request for review March 1, 2024 11:46
@jasa-odoo jasa-odoo changed the base branch from saas-16.2 to 17.0 March 1, 2024 13:24
@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch from c393bf6 to 1b88a7a Compare March 1, 2024 13:25
@jasa-odoo
Copy link
Contributor Author

Hello @lordkrandel ,
This task is done from my side and PO also tested it and validated it. so can you please review it?
Thanks

Copy link
Contributor

@lordkrandel lordkrandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

addons/l10n_in_edi/models/account_move.py Outdated Show resolved Hide resolved
addons/l10n_in_edi/models/account_move.py Outdated Show resolved Hide resolved
addons/l10n_in_edi/models/account_move.py Outdated Show resolved Hide resolved
addons/l10n_in_edi/models/account_move.py Outdated Show resolved Hide resolved
addons/l10n_in_edi/views/account_move_views.xml Outdated Show resolved Hide resolved
@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch from 1b88a7a to 8b3df01 Compare March 19, 2024 05:15
@jasa-odoo
Copy link
Contributor Author

Hello @lordkrandel ,
Thank you for your review. I've implemented the changes. Could you please take a moment to review the updates and ensure everything looks good? Additionally, could you kindly update the alert message specifications in the task pad?

@jasa-odoo
Copy link
Contributor Author

Hello @lordkrandel ,
Any updates on this?
Thank you :)

Copy link
Contributor

@lordkrandel lordkrandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@qdp-odoo for final review.

@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch from 8b3df01 to 8bfe416 Compare April 8, 2024 11:25
@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch from 8bfe416 to b9f68a8 Compare April 9, 2024 13:18
@jasa-odoo
Copy link
Contributor Author

Hello @qdp-odoo ,
Are there any updates on this?
Thank you.

<field name="display_null_pan_warning" invisible="1"/>
<div class="alert alert-warning main mb-0" role="alert"
invisible="not display_null_pan_warning">
If the partner has no PAN Number, please apply TDS / TCS at a higher rate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lack of alert may result in non-compliance with the Income Tax Act, causing practical difficulties for users and attracting penal consequences.

Shouldn't it be a hard constraint instead of a warning then?

Copy link

@shid-odoo shid-odoo May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @william-andre

To put a constraint, we have to set a higher rate for each TDS/TCS section. But since there's no place on the tax form for the system to check these rates, we can't put constraint.

Also, there are exceptions, like payments to non-residents who might not have PAN. In these cases, charging TDS/TCS at a higher rate isn't necessary even without PAN. So, if we make a rule, it might stop the process. Instead, we're just issuing a warning without making any firm rules.
2024-05-01_10-35

Comment on lines +48 to +49
"tax_tag_base_tds","BASE TDS","taxes"
"tax_tag_base_tcs","BASE TCS","taxes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We display a message when those tags are used.
So these tags mean "low rates", whatever that means?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We display a message when those tags are used. So these tags mean "low rates", whatever that means?

No, it doesn't mean low rate, it's just mean that TDS/TCS is applicable on this transaction at higher rate, as we don't have a field on taxes to define higher rate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use the tags to say that there is something with higher rates then?
Or the xmlids in stable and a field in master?
Or something else?

I just think that this warning is going to be confusing more than anything.

Copy link

@shid-odoo shid-odoo May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use the tags to say that there is something with higher rates then? Or the xmlids in stable and a field in master? Or something else?

I just think that this warning is going to be confusing more than anything.

Thank you for the idea. I think it's a good one, so we're updating the plan. Now we'll have tags: "High TDS" and "High TCS". We'll use these tags when the TDS/TCS rates are high. If either of those two tags is present and PAN isn't there, the system won't show an alert.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it make more sense to know which are not the highest rates, so that you know exactly when to have a warning/error?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it make more sense to know which are not the highest rates, so that you know exactly when to have a warning/error?

Yes, it makes sense. That's why we labeled regular rates as "BASE TDS" and "BASE TCS" and higher rates as "HIGH TDS" and "HIGH TCS."

Additionally, we're going to include these four labels in the new TDS report/spreadsheet we're making because the current one doesn't show the base amount.

@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch 4 times, most recently from c347475 to 6869f48 Compare May 6, 2024 16:07
Under Section 206AA/206AB of the Income Tax Act, 1961, if the PAN of a
Vendor/Customer is unavailable, TDS/TCS should be at a higher rate.

With this commit, whenever a user applies TDS/TCS and the PAN number is
absence of a partner, they will get an alert message to apply TDS/TCS at a
higher rate.

Task-3707451
@jasa-odoo jasa-odoo force-pushed the saas-16.2-l10n_in-imp-high-tds-warning-jasa branch from 6869f48 to 6db2423 Compare May 20, 2024 12:43
@jasa-odoo
Copy link
Contributor Author

Hello @william-andre ,
Any updates on this?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants