[FW][FIX] web: valid, then invalid, then valid field value is correct #155621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonGenin @aab-odoo cherrypicking of pull request #154991 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
The commit 7452f85 was fixing the problem in a simple way. It however wasn't good enough of a fix as we discovered we were triggering too many onChange after the forward port. So we revert commit 7452f85, and backport 5ffc604 from 17.1. It adds a method on the model to reset the validity of a field. It was not what felt the best, but as it is working and we just want to fix the problem in stable, we go for it. opw 3680495 X-original-commit: 35d49cc
SimonGenin
force-pushed
the
saas-16.2-16.0-web-field-invalid-fix-2-ges-bRjj-fw
branch
from
8d00885
to
5327b6f
Compare
|
@robodoo r+ |
C3POdoo
requested review from
a team,
Iucapad and
juliusc2066
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2024
The commit 7452f85 was fixing the problem in a simple way. It however wasn't good enough of a fix as we discovered we were triggering too many onChange after the forward port. So we revert commit 7452f85, and backport 5ffc604 from 17.1. It adds a method on the model to reset the validity of a field. It was not what felt the best, but as it is working and we just want to fix the problem in stable, we go for it. opw 3680495 closes #155621 X-original-commit: 35d49cc Signed-off-by: Aaron Bohy (aab) <aab@odoo.com> Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit odoo-dev@7452f85 was fixing the
problem in a simple way. It however wasn't good enough of a fix as we
discovered we were triggering too many onChange after the forward port.
So we revert commit odoo-dev@7452f85, and backport odoo-dev@5ffc604 from 17.1. It adds
a method on the model to reset the validity of a field.
It was not what felt the best, but as it is working and we just want to
fix the problem in stable, we go for it.
Forward-Port-Of: #155442
Forward-Port-Of: #154991