[IMP] base: avoid infinite loops in _update_category #155709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team,
rco-odoo and
ryv-odoo
and removed request for
a team
|
Hello @madprog IMHO, if you have broken data, you should fix that data instead of adding code in order to take in account for broken data (and the warning won't be seen by the user). But if it's really necessary (if there are already a lot of databases with this problem), please don't forward it to the master. |
|
@ryv-odoo we are still getting this issue in upgrades, and there is no simple way to fix it unless standard code is resilient to this case. Happening at least in 16.3 also. |
When updating the categories, if by any chance there is a loop in the category hierarchy, the current code was falling into an infinite loop. With this commit, the graph loop is broken by clearing a parent_id, and if the resulting module category path is wrong, a clean new one will be recreated anyway. This allows unblocking uncomfortable situations where people cannot update the modules list any more. In 15.0, [a check][1] has been introduced to prevent the existence of recursive categories, but as it is a python check it doesn't prevent corrupted data to remain corrupted. OPW-3704007 Related to odoo/upgrade#5574 [1]: odoo/odoo@6932714
KangOl
force-pushed
the
14.0-avoid_module_categ_loop-pmo
branch
from
b0c6897
to
d28fb7a
Compare
nseinlet
approved these changes
Apr 11, 2024
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 11, 2024
When updating the categories, if by any chance there is a loop in the category hierarchy, the current code was falling into an infinite loop. With this commit, the graph loop is broken by clearing a parent_id, and if the resulting module category path is wrong, a clean new one will be recreated anyway. This allows unblocking uncomfortable situations where people cannot update the modules list any more. In 15.0, [a check][1] has been introduced to prevent the existence of recursive categories, but as it is a python check it doesn't prevent corrupted data to remain corrupted. OPW-3704007 Related to odoo/upgrade#5574 [1]: 6932714 closes #155709 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the categories, if by any chance there is a loop in the category hierarchy, the current code was falling into an infinite loop.
With this commit, the graph loop is broken by clearing a parent_id, and if the resulting module category path is wrong, a clean new one will be recreated anyway.
This allows unblocking uncomfortable situations where people cannot update the modules list any more. In 15.0, a check has been introduced to prevent the existence of recursive categories, but as it is a python check it doesn't prevent corrupted data to remain corrupted.
OPW-3704007
Related to odoo/upgrade#5574