Master gamification cfa #15582
Merged
Master gamification cfa #15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-e
requested changes
Apr 11, 2017
| @@ -20,75 +20,245 @@ | |||
| <record id="simple_report_template" model="mail.template"> | |||
| <field name="name">Simple Challenge Report Progress</field> | |||
| <field name="model_id" ref="gamification.model_gamification_challenge"/> | |||
| <field name="subject">New badge granted</field> | |||
There was a problem hiding this comment.
Subject is wrong, should be something like "report for `
| <tr> | ||
| <td> | ||
| <span style="color:#A8A8A8;font-size:13px;"> | ||
| The following message contains the current progress for the challenge Monthly Sales Targets. |
There was a problem hiding this comment.
name of the challenge hardocded
|
|
||
| # goals closed but still opened at the last report date | ||
| closed_goals_to_report = Goals.search([ | ||
| ('challenge_id', '=', challenge.id), |
There was a problem hiding this comment.
should have no diff in the code
addons/gamification/models/goal.py
Outdated
| goal.completeness = 100.0 | ||
| else: | ||
| # if goal.current >= goal.target_goal: | ||
| # goal.completeness = 100.0 |
tde-banana-odoo
force-pushed
the
master-gamification-cfa
branch
from
3594b18
to
1a72731
Compare
mart-e
requested changes
May 9, 2017
| <td>${goal['current']}/${line['target']} | ||
| % if line['suffix']: | ||
| ${line['suffix']} | ||
| <field name="subject">New badge granted</field> |
There was a problem hiding this comment.
Why is the "Simple Challenge Report Progress" subject called "New badge granted"?
| <tr><td> | ||
| <table cellspacing="0" cellpadding="0" width="100%"> | ||
| <tr><td valign="middle" align="left" style="padding:30px 15px;"> | ||
| <img width="90" src="https://www.odoo.com/openerp_website/static/src/img/2016/logos/odoo_logo_small.png" style="width:80px;"/> |
There was a problem hiding this comment.
shouldn't this be on the local server?
| <table cellspacing="0" cellpadding="0" width="100%" style="padding: 15px;"> | ||
| <tr> | ||
| <td align="center" style="padding: 30px 15px;"> | ||
| <p style="font-size:12px;color:#AAAAAA">Odoo SA - Chaussée de Namur, 40, B-1367 Grand-Rosière</p> |
rrahir
force-pushed
the
master-gamification-cfa
branch
2 times, most recently
from
5d4e452
to
7feb85f
Compare
rrahir
force-pushed
the
master-gamification-cfa
branch
15 times, most recently
from
76f8da8
to
cb5edfa
Compare
rrahir
force-pushed
the
master-gamification-cfa
branch
8 times, most recently
from
f58a35c
to
daab587
Compare
rrahir
force-pushed
the
master-gamification-cfa
branch
from
daab587
to
f4eb358
Compare
rrahir
force-pushed
the
master-gamification-cfa
branch
3 times, most recently
from
9b55da2
to
b861191
Compare
Fix of the template. - removed most of the static code, - add user-specific information.
- Split templates for 'personal' and 'ranking'. - beug fixes - Code cleaning
rrahir
force-pushed
the
master-gamification-cfa
branch
2 times, most recently
from
5830dd4
to
04fbf4a
Compare
- removed report_template_id field, - force dedicated template for 'personal' and 'ranking, - fix image size on personal template. - code cleaning
rrahir
force-pushed
the
master-gamification-cfa
branch
from
04fbf4a
to
8fad2f6
Compare
rrahir
added a commit
that referenced
this pull request
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://www.odoo.com/web#id=30824&view_type=form&model=project.task&menu_id=5200