Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] l10n_id: show kode transaksi outside accounting #155994

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 29, 2024

Currently the field Kode Transaksi can be found inside the accounting tab. This fix will move it under the tax field. Kode Transaksi is a field that should be used in the sale flow and is currently unavailabe for sales team.

Steps to reproduce:

  • Install l10n_id
  • Create a company with indonesian localization
  • Switch to that company
  • Creat a contact
  • Toggle the checkbox next to Tax ID
  • Under the Accounting tab, you can find Kode transaksi. Sales team don't have access to the accounting tab, and thus not to Kode transaksi either.

Why the fix:

Technically what we want here is to have the field for Kode Transaksi after the vat field from this view

attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
</div>
<field name="vat" placeholder="e.g. BE0477472701" attrs="{'readonly': [('parent_id','!=',False)]}"/>
</group>
<group>
<field name="function" placeholder="e.g. Sales Director"

Two possible solutions for this fix:

  • Fetch the path to group/group and put the field inside.

  • Fetch the path to the vat field and put the field after. This would also require to change the priority of the view starting from saas-16.3 because the vat field is being moved in this view:

    <xpath expr="//div[@name='vat_vies_container']" position="inside">
    <xpath expr="//field[@name='vat']" position="move"/>
    <label for="vies_valid" invisible="not perform_vies_validation"/>
    <field name="vies_valid" invisible="not perform_vies_validation" class="oe_inline"/>
    </xpath>

    By changing the priority, it would allow for Kode transaksi to be place after the vat_vies_container. Else it would be inside, which does not make sense inthis case.

opw-3731357

Forward-Port-Of: #155515

Currently the field `Kode Transaksi` can be found inside the accounting tab. This fix will move it under the tax field. `Kode Transaksi` is a field that should be used in the sale flow and is currently unavailabe for sales team.

Steps to reproduce:
-------------------
* Install **l10n_id**
* Create a company with indonesian localization
* Switch to that company
* Creat a contact
* Toggle the checkbox next to `Tax ID`
* Under the `Accounting` tab, you can find `Kode transaksi`. Sales team don't have access to the accounting tab, and thus not to `Kode transaksi` either.

Why the fix:
------------
Technically what we want here is to have the field for `Kode Transaksi` after the `vat` field from this view

https://github.com/odoo/odoo/blob/04593b265b765f7a6ee079f21bad6a1cf0e5d094/odoo/addons/base/views/res_partner_views.xml#L205-L210

Two possible solutions for this fix:
* Fetch the path to `group/group` and put the field inside.
* Fetch the path to the `vat` field and put the field after. This would also require to change the priority of the view starting from saas-16.3 because the `vat` field is being moved in this view:

  https://github.com/odoo/odoo/blob/8ccde3f101cdb6ca41fe29cc5b4252f13745774a/addons/base_vat/views/res_partner_views.xml#L14-L18

  By changing the priority, it would allow for `Kode transaksi` to be place after the `vat_vies_container`. Else it would be inside, which does not make sense inthis case.

opw-3731357

X-original-commit: 32f1ae8
@robodoo
Copy link
Contributor

robodoo commented Feb 29, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 29, 2024

This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Feb 29, 2024
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Feb 29, 2024
robodoo pushed a commit that referenced this pull request Mar 1, 2024
Currently the field `Kode Transaksi` can be found inside the accounting tab. This fix will move it under the tax field. `Kode Transaksi` is a field that should be used in the sale flow and is currently unavailabe for sales team.

Steps to reproduce:
-------------------
* Install **l10n_id**
* Create a company with indonesian localization
* Switch to that company
* Creat a contact
* Toggle the checkbox next to `Tax ID`
* Under the `Accounting` tab, you can find `Kode transaksi`. Sales team don't have access to the accounting tab, and thus not to `Kode transaksi` either.

Why the fix:
------------
Technically what we want here is to have the field for `Kode Transaksi` after the `vat` field from this view

https://github.com/odoo/odoo/blob/04593b265b765f7a6ee079f21bad6a1cf0e5d094/odoo/addons/base/views/res_partner_views.xml#L205-L210

Two possible solutions for this fix:
* Fetch the path to `group/group` and put the field inside.
* Fetch the path to the `vat` field and put the field after. This would also require to change the priority of the view starting from saas-16.3 because the `vat` field is being moved in this view:

  https://github.com/odoo/odoo/blob/8ccde3f101cdb6ca41fe29cc5b4252f13745774a/addons/base_vat/views/res_partner_views.xml#L14-L18

  By changing the priority, it would allow for `Kode transaksi` to be place after the `vat_vies_container`. Else it would be inside, which does not make sense inthis case.

opw-3731357

closes #155994

X-original-commit: 32f1ae8
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Sarah Bellefroid (sbel) <sbel@odoo.com>
@robodoo robodoo closed this Mar 1, 2024
@fw-bot fw-bot deleted the saas-16.2-15.0-opw-3731357-kode_transaski-sbel-T83P-fw branch March 15, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants