Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] stock: add automated way to fix unreserve issue #156035

Commits on Mar 1, 2024

  1. [FIX] stock: add automated way to fix unreserve issue

    When there is a discrepancy of reserved quantity between `stock.quant.reserved_quantity` and `stock.move.line.product_qty` the UserError 'It is not possible to unreserve more products of %s than you
    have in stock' is raised.
    This discrepancy can be caused by past bug, customization or direct manipulation of `stock.quant` or `stock.move.line` by the users.
    Once this discrepancy is present, it will not disappear by itself.
    
    Currently, there is no functional method to fix these discrepancies, the user encountering this message is stuck until they contact the Odoo support team.
    
    Ideally, we would fix every bug related to the reservation so that this UserError almost never appears.
    However, even after multiple bugs fixed (ex: odoo#144176 , odoo#154327 ) and multiple years of feedback, the users keep encountering this error and keep getting stuck when validating/cancelling transfers.
    
    So the idea is to re-introduce a server action like it was done for Odoo 13 & Odoo 14 2 years ago: d99e173 to the current stable version (except the latest one Odoo 17 as we do not have enough perspectives on this version).
    
    The server action checks all the quants and their relative move line to check if match correctly. If not, it will remove the reservation from both.
    It could remove the reservation from some unrelated `pickings` and `stock.move`
    
    Forward-Port of odoo#79180
    Related to odoo#62139
    
    X-original-commit: e0e63be
    Co-authored-by: Arnold Moyaux <arm@odoo.com>
    DavidFesquet and amoyaux committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d488de1 View commit details
    Browse the repository at this point in the history