Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] misc: gitignore windows config file #156099

Closed
wants to merge 1 commit into from

Conversation

bram1000
Copy link
Contributor

@bram1000 bram1000 commented Mar 1, 2024

On Windows installations there is a odoo.conf file generated in the root directory containing a hashed admin password.

This only happens in Windows installations where the config file location is not specified. The code responsible can be found here:

rcfilepath = os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), 'odoo.conf')

On Windows installations there is a odoo.conf file generated
in the root directory containing a hashed admin password.

This only happens in Windows installations where the config file
location is not specified. The code responsible can be found here:
https://github.com/odoo/odoo/blob/d2ccea9a292c02dc6f4cfdb960d22caa0fd98fd5/odoo/tools/config.py#L414
@robodoo
Copy link
Contributor

robodoo commented Mar 1, 2024

@bram1000 bram1000 requested a review from mart-e March 1, 2024 14:06
@bram1000 bram1000 self-assigned this Mar 1, 2024
@C3POdoo C3POdoo requested a review from a team March 1, 2024 14:17
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 1, 2024
Copy link
Contributor

@mart-e mart-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as winows ccing @d-fence

@d-fence
Copy link
Contributor

d-fence commented Mar 1, 2024

robodoo r+

@bram1000 bram1000 requested review from d-fence and removed request for d-fence March 1, 2024 16:01
robodoo pushed a commit that referenced this pull request Mar 1, 2024
On Windows installations there is a odoo.conf file generated
in the root directory containing a hashed admin password.

This only happens in Windows installations where the config file
location is not specified. The code responsible can be found here:
https://github.com/odoo/odoo/blob/d2ccea9a292c02dc6f4cfdb960d22caa0fd98fd5/odoo/tools/config.py#L414

closes #156099

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
@robodoo robodoo closed this Mar 1, 2024
@fw-bot fw-bot deleted the 15.0-gitignore-odooconf-brvg branch March 15, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants