-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] tools: patch fixed Arabic class from newer version of num2words. #156286
Conversation
0ae4bcc
to
2a3e80a
Compare
81828ed
to
baf1900
Compare
baf1900
to
9a2a938
Compare
3b7309f
to
4f295f2
Compare
4484357
to
6901edd
Compare
6901edd
to
99aa23a
Compare
46a0429
to
8362d0e
Compare
8362d0e
to
9189698
Compare
robodoo r+ |
closes #156286 Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
@MohammedBasioni @oomsveta this pull request has forward-port PRs awaiting action (not merged or closed): |
@MohammedBasioni @oomsveta this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
@MohammedBasioni @oomsveta this pull request has forward-port PRs awaiting action (not merged or closed): |
@MohammedBasioni @oomsveta this pull request has forward-port PRs awaiting action (not merged or closed): |
@MohammedBasioni The IoT box uses odoo's community code for its core features with it's own requirement. I will see with the IoT team if we can solve that on our end without modifying your file, but likely not (as we need to build new IoT OS images for library changes and reflash SD cards). Just be aware of this in case other people come to you on the matter and I'll come back to you if needed |
patch fixed Arabic class from newer version of num2words package.
Description of the issue/feature this PR addresses
the num2words library does not correctly convert some numbers to words in Arabic. It erroneously appends the Arabic equivalent of "one" to the translation of 1000 (one thousand), when it must be implicit. Also, it was noticed that this behaviour happens in all multiple of 1000s. It appends 'one' to million and billion, etc.
Current behaviour before PR
Desired behaviour after PR is merged: