Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] mrp_subcontracting: changing UoM causes unreserve issues #156333

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 4, 2024

Before this commit:
"Cannot unreserve more than you have in stock" Error
It was possible to purchase a subcontracted product, and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved. This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant.

After this commit:
The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done.

OPW-3742720

Forward-Port-Of: #154450
Forward-Port-Of: #154327

Before this commit:
It was possible to purchase a subcontracted product and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved.
This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant.

After this commit:
The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done.

OPW-3742720

X-original-commit: c6c8e60
@robodoo
Copy link
Contributor

robodoo commented Mar 4, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 4, 2024

This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 4, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 4, 2024
robodoo pushed a commit that referenced this pull request Mar 5, 2024
Before this commit:
It was possible to purchase a subcontracted product and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved.
This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant.

After this commit:
The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done.

OPW-3742720

closes #156333

X-original-commit: c6c8e60
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
@robodoo robodoo closed this Mar 5, 2024
@fw-bot fw-bot deleted the saas-16.2-15.0-OPW-3742720-mrp_subcontracting-uom_unreserve-pno-EYpo-fw branch March 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants