[FIX] base_import_module: activate from form view and upgrade #157008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vava-odoo
reviewed
Mar 14, 2024
There was a problem hiding this comment.
Hi @arpa-odoo
Thanks for this! I validate the part on the form view, but I don't get the "upgrade" part.
Also, while you're at it, could you also fix the tree view?
Cheers!
arpa-odoo
force-pushed
the
17.0-base_import_module-fix-activate-arpa
branch
from
d630e49
to
6557088
Compare
arpa-odoo
force-pushed
the
17.0-base_import_module-fix-activate-arpa
branch
from
6557088
to
b3646a3
Compare
vava-odoo
reviewed
Mar 27, 2024
Before this commit ================== Unable to activate the industry from the form view in the industry section. Additionally, the button in the form for upgrading would be called the button_immediate_upgrade method, resulting in errors. After this commit ================= Activation of the industry from the form view in the industry section is now possible. Furthermore, the issue with upgrading the industry from the form view has been resolved. task-3775729
arpa-odoo
force-pushed
the
17.0-base_import_module-fix-activate-arpa
branch
from
b3646a3
to
04f14f8
Compare
vava-odoo
approved these changes
Mar 27, 2024
C3POdoo
requested review from
a team,
xmo-odoo and
HydrionBurst
and removed request for
a team
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
This was referenced Mar 27, 2024
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
Before this commit ================== Unable to activate the industry from the form view in the industry section. Additionally, the button in the form for upgrading would be called the button_immediate_upgrade method, resulting in errors. After this commit ================= Activation of the industry from the form view in the industry section is now possible. Furthermore, the issue with upgrading the industry from the form view has been resolved. task-3775729 closes odoo#157008 Signed-off-by: Pierre Masereel (pim) <pim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit
Unable to activate the industry from the form view in the industry section. Additionally, the button in the form for upgrading would be called the button_immediate_upgrade method, resulting in errors.
After this commit
Activation of the industry from the form view in the industry section is now possible. Furthermore, the issue with upgrading the industry from the form view has been resolved.
task-3775729