[FIX] l10n_id: adapt the check to the new VAT regulation

[amay-odoo]

The issue:
Currently, in Indonesia, the regulation for tax ID is 15 digits.
But a new regulation is coming where Tax ID is now 16 digits by adding 0 in front

The fix:
Remove the first zero and leave the rest for the _run_vat_test function

Related PR: #146111

opw-3782636

[robodoo]

Pull request status dashboard.

[lordkrandel]

Hello, sorry, but fix has an error:
I get a ValidationError when submitting an Italian partner with a VAT that starts with 0.

I don't also see the PO @tsb-odoo being asked whether removing the leading 0 is the correct way to go.

Probably _run_vat_check is not the correct function to use.
Please have a look inside the base_vat code:

• the current Indonesian VAT check
• a format function for CH VATs
• one level up the stack
• two levels up the stack

[amay-odoo]

Hello @lordkrandel , thank you for your review and help on this PR, I've made new changes and it should work now, could you please have a look?
thanks

[lordkrandel]

Well, this PR really shortened, didn't it 😅
LGTM.

There's an ugly line just before your change:

It should be:

    if len(vat) not in (15, 16) or not vat.is_decimal():

but maybe it's not worth the diff at the moment.

@qdp-odoo for final review.

[amay-odoo]

Hello @qdp-odoo , would you mind please looking at this PR when you are available? Thanks :)

[qdp-odoo]

@robodoo r+
@lordkrandel good job, nice review 👍

[lordkrandel]

@lordkrandel good job, nice review 👍

Thank you @qdp-odoo ! 🤝

[fw-bot]

@amay-odoo @qdp-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163633
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163653
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163673

[fw-bot]

@amay-odoo @qdp-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163633
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163653
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163673

[fw-bot]

@amay-odoo @qdp-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163633
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163653
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163673

[fw-bot]

@amay-odoo @qdp-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163633
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163653
• [FW][FIX] l10n_id: adapt the check to the new VAT regulation #163673