[FIX] mrp,stock: compute correct quantity for stock move #158166

mattismegevand · 2024-03-19T16:31:35Z

Steps to reproduce:

Install MRP
Enable packages and multi-step routes
Enable two steps manufacturing
Create a component and a product
Create a BOM for the product and add the component
Make an MO for 100 units of the product
Go to the picking and make a move of 20 units of the component with a
destination package
Put in pack
Create the backorder and validate the transfer of the remaining
components
Go back to the MO

Issues:
Units reserved is wrong. The problem is when we are unpacking, we were
using result package inside the key. But what we want is to remove
quantity from the package the quantity originate from.

opw-3759006

robodoo · 2024-03-19T16:32:21Z

Pull request status dashboard.

adwid

Makes sense to me

The explanations could really be more accurate:

>>>>>>
When computing the available qty, we do "qty in - qty out":

odoo/addons/stock/models/stock_move.py

Lines 1505 to 1507 in f17ae54

    
           grouped_move_lines_in = self._get_available_move_lines_in() 
        
           grouped_move_lines_out = self._get_available_move_lines_out(assigned_moves_ids, partially_available_moves_ids) 
        
           available_move_lines = {key: grouped_move_lines_in[key] - grouped_move_lines_out.get(key, 0) for key in grouped_move_lines_in}

Where the key is a tuple with few information, among them:

The result package for incoming moves:

odoo/addons/stock/models/stock_move.py

Lines 1465 to 1466 in f17ae54

    
           def _keys_in_sorted(ml): 
        
               return (ml.location_dest_id.id, ml.lot_id.id, ml.result_package_id.id, ml.owner_id.id)

The source package for the outgoing moves:

odoo/addons/stock/models/stock_move.py

Lines 1490 to 1491 in f17ae54

def _keys_out_sorted(ml):

return (ml.location_id.id, ml.lot_id.id, ml.package_id.id, ml.owner_id.id)

Back to _action_assign, the move should be considered as an outgoing one: we are using the qty brought by the incoming moves. So, its key definition should be the same as the one of its siblings: based on the source package
<<<<<<

About the test, we try to use records of the setup as much as possible. I have added some suggestions so you can use one of the available BoMs and make the test shorter/simpler

addons/mrp/tests/test_stock.py

adwid · 2024-03-27T13:29:35Z

addons/mrp/tests/test_stock.py

+        warehouse = self.env['stock.warehouse'].search([('company_id', '=', self.env.company.id)], limit=1)
+        warehouse.write({'manufacture_steps': 'pbm'})
+
+        self.env['stock.quant']._update_available_quantity(component, self.stock_location, 100)


Suggested change

self.env['stock.quant']._update_available_quantity(component, self.stock_location, 100)

self.product_1.type = 'product'

self.env['stock.quant']._update_available_quantity(self.product_1, self.stock_location, 100)

addons/mrp/tests/test_stock.py

Steps to reproduce: - Install MRP - Enable packages and multi-step routes - Enable two steps manufacturing - Create a component and a product - Create a BOM for the product and add the component - Make an MO for 100 units of the product - Go to the picking and make a move of 20 units of the component with a destination package - Put in pack - Create the backorder and validate the transfer of the remaining components - Go back to the MO Issues: Units reserved is wrong. The problem is when we are unpacking, we were using result package inside the key. But what we want is to remove quantity from the package the quantity originate from. opw-3759006

Whenrow · 2024-03-28T15:11:05Z

robodoo r+

Steps to reproduce: - Install MRP - Enable packages and multi-step routes - Enable two steps manufacturing - Create a component and a product - Create a BOM for the product and add the component - Make an MO for 100 units of the product - Go to the picking and make a move of 20 units of the component with a destination package - Put in pack - Create the backorder and validate the transfer of the remaining components - Go back to the MO Issues: Units reserved is wrong. The problem is when we are unpacking, we were using result package inside the key. But what we want is to remove quantity from the package the quantity originate from. opw-3759006 closes #158166 Signed-off-by: William Henrotin (whe) <whe@odoo.com>

fw-bot · 2024-04-01T05:53:47Z

@mattismegevand @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2024-04-02T05:54:37Z

@mattismegevand @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2024-04-03T05:54:10Z

@mattismegevand @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2024-04-04T05:54:18Z

@mattismegevand @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][FIX] mrp,stock: compute correct quantity for stock move #160258

Steps to reproduce: - Install MRP - Enable packages and multi-step routes - Enable two steps manufacturing - Create a component and a product - Create a BOM for the product and add the component - Make an MO for 100 units of the product - Go to the picking and make a move of 20 units of the component with a destination package - Put in pack - Create the backorder and validate the transfer of the remaining components - Go back to the MO Issues: Units reserved is wrong. The problem is when we are unpacking, we were using result package inside the key. But what we want is to remove quantity from the package the quantity originate from. opw-3759006 closes odoo#158166 Signed-off-by: William Henrotin (whe) <whe@odoo.com>

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 19, 2024

mattismegevand force-pushed the 15.0-opw-3759006-stock_move_quantity_miscalculation-mmeg branch 3 times, most recently from d1b8b66 to f17ae54 Compare March 27, 2024 10:01

adwid reviewed Mar 27, 2024

View reviewed changes

mattismegevand force-pushed the 15.0-opw-3759006-stock_move_quantity_miscalculation-mmeg branch from f17ae54 to 69d2f9e Compare March 28, 2024 12:13

mattismegevand changed the title ~~[FIX] stock: compute correct quantity for stock move~~ [FIX] mrp, stock: compute correct quantity for stock move Mar 28, 2024

mattismegevand changed the title ~~[FIX] mrp, stock: compute correct quantity for stock move~~ [FIX] mrp,stock: compute correct quantity for stock move Mar 28, 2024

mattismegevand force-pushed the 15.0-opw-3759006-stock_move_quantity_miscalculation-mmeg branch from 69d2f9e to 136657f Compare March 28, 2024 12:14

mattismegevand marked this pull request as ready for review March 28, 2024 12:14

adwid approved these changes Mar 28, 2024

View reviewed changes

C3POdoo requested a review from a team March 28, 2024 12:19

robodoo temporarily deployed to merge March 28, 2024 21:24 Inactive

robodoo closed this Mar 28, 2024

This was referenced Mar 28, 2024

[FW][FIX] mrp,stock: compute correct quantity for stock move #159810

Closed

[FW][FIX] mrp,stock: compute correct quantity for stock move #159990

Closed

[FW][FIX] mrp,stock: compute correct quantity for stock move #160008

Closed

fw-bot deleted the 15.0-opw-3759006-stock_move_quantity_miscalculation-mmeg branch April 11, 2024 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] mrp,stock: compute correct quantity for stock move #158166

[FIX] mrp,stock: compute correct quantity for stock move #158166

mattismegevand commented Mar 19, 2024 •

edited

robodoo commented Mar 19, 2024

adwid left a comment •

edited

adwid Mar 27, 2024

Whenrow commented Mar 28, 2024

fw-bot commented Apr 1, 2024

fw-bot commented Apr 2, 2024

fw-bot commented Apr 3, 2024

fw-bot commented Apr 4, 2024

	grouped_move_lines_in = self._get_available_move_lines_in()
	grouped_move_lines_out = self._get_available_move_lines_out(assigned_moves_ids, partially_available_moves_ids)
	available_move_lines = {key: grouped_move_lines_in[key] - grouped_move_lines_out.get(key, 0) for key in grouped_move_lines_in}

	def _keys_in_sorted(ml):
	return (ml.location_dest_id.id, ml.lot_id.id, ml.result_package_id.id, ml.owner_id.id)

	def _keys_out_sorted(ml):
	return (ml.location_id.id, ml.lot_id.id, ml.package_id.id, ml.owner_id.id)

	self.env['stock.quant']._update_available_quantity(component, self.stock_location, 100)
	self.product_1.type = 'product'
	self.env['stock.quant']._update_available_quantity(self.product_1, self.stock_location, 100)

[FIX] mrp,stock: compute correct quantity for stock move #158166

[FIX] mrp,stock: compute correct quantity for stock move #158166

Conversation

mattismegevand commented Mar 19, 2024 • edited

robodoo commented Mar 19, 2024

adwid left a comment • edited

Choose a reason for hiding this comment

adwid Mar 27, 2024

Choose a reason for hiding this comment

Whenrow commented Mar 28, 2024

fw-bot commented Apr 1, 2024

fw-bot commented Apr 2, 2024

fw-bot commented Apr 3, 2024

fw-bot commented Apr 4, 2024

mattismegevand commented Mar 19, 2024 •

edited

adwid left a comment •

edited