Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] payment: improve allow unarchiving the archived tokens #158328

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rupa-odoo
Copy link
Contributor

Before this commit,
When a payment method or payment provider was deactivated the tokens linked to it were also getting archived and they were prohibited from being active again.

After this commit, the tokens can be unarchived but if the linked pm and the pp if both are active.

task-3756355

@robodoo
Copy link
Contributor

robodoo commented Mar 20, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 20, 2024
@rupa-odoo rupa-odoo force-pushed the master-payment-unarchive-tokens-rupa branch from 16b0078 to 6b74440 Compare March 20, 2024 11:59
Copy link
Contributor

@kcv-odoo kcv-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you work! 💯
Added 2 comments to look into it

addons/payment/models/payment_token.py Outdated Show resolved Hide resolved
addons/payment/tests/test_payment_token.py Outdated Show resolved Hide resolved
@rupa-odoo rupa-odoo force-pushed the master-payment-unarchive-tokens-rupa branch 4 times, most recently from a3ba8f1 to ec36f8f Compare April 25, 2024 12:36
addons/payment/models/payment_token.py Outdated Show resolved Hide resolved
@rupa-odoo rupa-odoo force-pushed the master-payment-unarchive-tokens-rupa branch 2 times, most recently from 42130f6 to e05c509 Compare April 25, 2024 13:35
@rupa-odoo rupa-odoo force-pushed the master-payment-unarchive-tokens-rupa branch from e05c509 to fab2d4e Compare April 26, 2024 06:45
Before this commit,
When a payment method or payment provider was deactivated the
tokens linked to it were also getting archived and they were prohibited from
being active again.

After this commit, the tokens can be unarchived but if the linked pm and the
pp if both are active.

task-3756355
@rupa-odoo rupa-odoo force-pushed the master-payment-unarchive-tokens-rupa branch from fab2d4e to 44e9737 Compare April 30, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants