[IMP] web: views don't need action manager to scroll #158539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team,
aab-odoo and
kebeclibre
and removed request for
a team
|
do you see any issues with this @stefanorigano ? |
I haven't tested all the views, but the the SCSS makes sense and seems to behave correctly. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 27, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 27, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
|
@juliusc2066 @Polymorphe57 linked pull request(s) odoo/enterprise#59151 not ready. Linked PRs are not staged until all of them are ready. |
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329
juliusc2066
force-pushed
the
master-view-scrollbar-without-action-manager-juca
branch
from
b73d918
to
8444821
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file. task-3820329 closes #158539 Related: odoo/enterprise#59151 Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the overflow property for the o_content class inside the webclient to a more general scope where we don't need an action manager and an action to apply it. This allows to have a scrollbar inside tests without the need of spawning a webclient. Also removes useless duplicate rules from the same file.
task-3820329