[FW][FIX] base_import: fix background color in dark mode #158822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anso-odoo @pparidans cherrypicking of pull request #158019 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
This commit adapts `base_import`'s background that was too dark compared to other modules. This was caused by the use of a `bg-white` class that is not very "dark-mode friendly" as it will display as a pure black, which is not visually appealing and not wanted. This commit also adapts the background color of the sidebar to make it more consistent with other modules. We also add a `bg-view` class to the table, so it stands out more in light mode and stays the same in dark mode. task-3814508 X-original-commit: 5713192
pparidans
force-pushed
the
17.0-saas-16.3-base-import-dark-mode-fix-anso-uziY-fw
branch
from
3f46152
to
ecac2c0
Compare
C3POdoo
requested review from
a team,
rco-odoo and
ryv-odoo
and removed request for
a team
pparidans
approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
This commit adapts `base_import`'s background that was too dark compared to other modules. This was caused by the use of a `bg-white` class that is not very "dark-mode friendly" as it will display as a pure black, which is not visually appealing and not wanted. This commit also adapts the background color of the sidebar to make it more consistent with other modules. We also add a `bg-view` class to the table, so it stands out more in light mode and stays the same in dark mode. task-3814508 closes odoo#158822 X-original-commit: 5713192 Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts
base_import's background that was too dark compared to other modules. This was caused by the use of abg-whiteclass that is not very "dark-mode friendly" as it will display as a pure black, which is not visually appealing and not wanted.This commit also adapts the background color of the sidebar to make it more consistent with other modules.
We also add a
bg-viewclass to the table, so it stands out more in light mode and stays the same in dark mode.task-3814508
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #158019