[FW][FIX] sale_management: dispense temp cache records #158950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Current behavior:**
If a recurring sale order has an associated sale order option
and the recurring plan of the order is changed, a trace back
occurs.
**Expected behavior:**
The recurring plan can be changed as it ordinarily would.
**Steps to reproduce:**
1. Add a recurring product to a sale order
2. Add an optional recurring product to the order
3. Try to change the recurring plan of the order to encounter
the trace back
**Cause of the issue:**
This flow causes some 'phantom' sale order lines to have their
price recalculated (phantom because they have no price, qty,
currency, nor order_id field values). During this recalculation
a currency_id is expected either in the line itself or in the
sale order it is a part of. Because there is no value for either
of these, it fails the ensure_one() method in the sequence
(0 vals, expects 1).
The phantom lines are created in the `sale.order.option` model
in the `sale_management` module, in `_compute_price_unit()` and
`_compute_discount()`.
**Fix:**
Call `invalidate_recorset(flush=False)` on these cached records
at the end of the methods in which they are created.
opw-3754297
X-original-commit: 16f51c9
|
@ethanrobv while this was properly forward-ported, at least one co-dependent PR (odoo/enterprise#59301) did not succeed. You will need to fix it before this can be merged. Both this PR and the others will need to be approved via More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
|
@robodoo r+ |
|
@arj-odoo you may want to rebuild or fix this PR as it has failed CI. |
|
@ethanrobv @arj-odoo linked pull request(s) odoo/enterprise#59301 not ready. Linked PRs are not staged until all of them are ready. |
|
@robodoo retry |
|
I'm sorry, @ethanrobv: retry makes no sense when the PR is not in error. |
This was referenced Mar 28, 2024
fw-bot
deleted the
17.0-16.0-opw-3754297-recurring-order-with-option-change-plan-etvi-bSjT-fw
branch
ethanrobv
restored the
17.0-16.0-opw-3754297-recurring-order-with-option-change-plan-etvi-bSjT-fw
branch
ethanrobv
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 15, 2024
**Current behavior:**
Creating a subscription order and adding an order line and order
option before setting the recurrence plan will result in an
empty order line being added to the order.
(All fields null/empty/false)
**Expected behavior:**
Setting the recurrence plan will not create a new order line.
**Steps to reproduce:**
1. Create a subscription order
2. Add an recurring product as an order line and an optional
recurring product
3. Give the order a recurring plan
4. Observe the new empty order line
**Cause of the issue:**
When processing the onchange methods which depend on `plan_id`,
we will call `_compute_price_unit()` and _compute_discount()` in
`sale_management : sale.order.option`, where we create some temp
records to perform the respective computations. These temporary
records are not being sufficiently invalidated.
Prior to odoo#158950 we "dispensed"
these temp records by setting their `order_id` to False- this
issue still occurs even using that method of exclusion.
**Fix:**
Fetch the `order_line` to ensure we have an
up-to-date reference.
This PR fixes the test added by:
odoo/enterprise@64685cd
which broke in the 17.0 fw-port:
odoo/enterprise@ab3cf34
opw-3754297
ethanrobv
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 15, 2024
**Current behavior:**
Creating a subscription order and adding an order line and order
option before setting the recurrence plan will result in an
empty order line being added to the order.
(All fields null/empty/false)
**Expected behavior:**
Setting the recurrence plan will not create a new order line.
**Steps to reproduce:**
1. Create a subscription order
2. Add an recurring product as an order line and an optional
recurring product
3. Give the order a recurring plan
4. Observe the new empty order line
**Cause of the issue:**
When processing the onchange methods which depend on `plan_id`,
we will call `_compute_price_unit()` and _compute_discount()` in
`sale_management : sale.order.option`, where we create some temp
records to perform the respective computations. These temporary
records are not being sufficiently invalidated.
Prior to odoo#158950 we "dispensed"
these temp records by setting their `order_id` to False- this
issue still occurs even using that method of exclusion.
**Fix:**
Fetch the `order_line` to ensure we have an
up-to-date reference.
This PR fixes the test added by:
odoo/enterprise@64685cd
which broke in the 17.0 fw-port:
odoo/enterprise@ab3cf34
opw-3754297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
If a recurring sale order has an associated sale order option and the recurring plan of the order is changed, a trace back occurs.
Expected behavior:
The recurring plan can be changed as it ordinarily would.
Steps to reproduce:
Add a recurring product to a sale order
Add an optional recurring product to the order
Try to change the recurring plan of the order to encounter the trace back
Cause of the issue:
This flow causes some 'phantom' sale order lines to have their price recalculated (phantom because they have no price, qty, currency, nor order_id field values). During this recalculation a currency_id is expected either in the line itself or in the sale order it is a part of. Because there is no value for either of these, it fails the ensure_one() method in the sequence (0 vals, expects 1).
The phantom lines are created in the
sale.order.optionmodel in thesale_managementmodule, in_compute_price_unit()and_compute_discount().Fix:
Call
invalidate_recorset(flush=False)on these cached records at the end of the methods in which they are created.Test added in https://github.com/odoo/enterprise/pull/58264
opw-3754297
Forward-Port-Of: #157515