[IMP] hr : allow department's view for every user #159048
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mepe-odoo
force-pushed
the
master-hr-department_visibility-mepe
branch
from
aa24f47
to
bd9ab5d
Compare
|
|
mepe-odoo
force-pushed
the
master-hr-department_visibility-mepe
branch
2 times, most recently
from
f56a9bb
to
bfed075
Compare
|
@mepe-odoo hello, maybe i'm wrong but this feels a bit hacky, can't we achieve the same result with implied groups and ir rules ? |
addons/hr/models/hr_department.py
Outdated
| @@ -132,6 +141,28 @@ def action_plan_from_department(self): | |||
| action['context'] = {'default_department_id': self.id, 'search_default_department_id': self.id} | |||
| return action | |||
|
|
|||
| def action_employee_from_department(self): | |||
There was a problem hiding this comment.
check get_view on hr_employee
mepe-odoo
force-pushed
the
master-hr-department_visibility-mepe
branch
from
bfed075
to
6e5599a
Compare
With this commit, every manager will be able to see department section even if he doesn't have any hr's right to help him to see what's happening in his department. task: 3817672
mepe-odoo
force-pushed
the
master-hr-department_visibility-mepe
branch
from
6e5599a
to
c27f191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, every user will be able to see department section even if he doesn't have any hr's right to help him to see what's happening in his department.
task: 3817672
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr