[FIX] account: fixed import name for account test case #159112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team and
hupo-odoo
and removed request for
a team
atp-odoo
force-pushed
the
saas-16.3-fix-import-code-translation-atp
branch
from
30a8597
to
7c5c580
Compare
It appears that during an upgrade process, there was an ImportError
due to a change in the import statement for the code_translations
function within the odoo.addons.account.models.chart_template module.
The correct import should be from odoo.tools.translate,
not from odoo.addons.account.models.chart_template.
```
from odoo.tools.translate import get_python_translations
```
The traceback indicates that the error occurred in the test file test_chart_template.py.
Here's the formatted error message:
```
File "/home/odoo/src/odoo/17.0/addons/stock_account/tests/test_account_move.py", line 4, in <module>
from odoo.addons.account.tests.common import AccountTestInvoicingCommon
File "/home/odoo/src/odoo/17.0/addons/account/tests/__init__.py", line 22, in <module>
from . import test_chart_template
File "/home/odoo/src/odoo/17.0/addons/account/tests/test_chart_template.py", line 4, in <module>
from odoo.addons.account.models.chart_template import code_translations
ImportError: cannot import name 'code_translations' from 'odoo.addons.account.models.chart_template' (/home/odoo/src/odoo/17.0/addons/account/models/chart_template.py)
```
atp-odoo
force-pushed
the
saas-16.3-fix-import-code-translation-atp
branch
from
7c5c580
to
3165d0c
Compare
hupo-odoo
reviewed
Mar 26, 2024
| with patch.object(code_translations, 'python_translations', mock_python_translations): | ||
| with patch.object(code_translations, 'get_python_translations', mock_python_translations): |
There was a problem hiding this comment.
Hello, thanks for the PR. Why do you do this change ? Your commit message does not explain why you change the dictionary object python_translations to the function get_python_translations. This is wrong since mock_python_translations is itself a dictionary. The error you get with the upgrade seems only related to the wrong import, not this test. With your change, the test TestChartTemplate.test_install_with_translations is failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During upgrade got the import name error:
File "/home/odoo/src/odoo/17.0/addons/stock_account/tests/test_account_move.py", line 4, in
from odoo.addons.account.tests.common import AccountTestInvoicingCommon
File "/home/odoo/src/odoo/17.0/addons/account/tests/init.py", line 22, in
from . import test_chart_template
File "/home/odoo/src/odoo/17.0/addons/account/tests/test_chart_template.py", line 4, in
from odoo.addons.account.models.chart_template import code_translations
ImportError: cannot import name 'code_translations' from 'odoo.addons.account.models.chart_template' (/home/odoo/src/odoo/17.0/addons/account/models/chart_template.py)