[FW][FIX] mail: incorrect unread counter on message post #159190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsm-odoo cherrypicking of pull request #158087 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
tsm-odoo
force-pushed
the
saas-17.2-saas-17.1-fix_unread_counter-tsm-xfMJ-fw
branch
from
2e8947f
to
bc03a9c
Compare
tsm-odoo
force-pushed
the
saas-17.2-saas-17.1-fix_unread_counter-tsm-xfMJ-fw
branch
2 times, most recently
from
134c78c
to
b776640
Compare
Before this PR, a race condition occurred when posting a message: if the bus notification was received before the result of the message post RPC, the unread counter was set to the number of messages in the channel. This occurs because the `discuss.channel.member/seen` notification is processed before the `discuss.channel/new_message` one so the message is not yet inserted in `thread.messages`. Actually, the channel seen notification is not needed in this case: the last seen message of the author is the message received in the new message notification. Steps to reproduce the issue: - Go to discuss as admin - Open a chat with demo - Set network throttling to "fast 3g" - Send a message in the chat - The unread counter is now set to "1" which is incorrect X-original-commit: 4a57322
tsm-odoo
force-pushed
the
saas-17.2-saas-17.1-fix_unread_counter-tsm-xfMJ-fw
branch
from
b776640
to
4427327
Compare
|
@robodoo override=ci/security |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2024
Before this PR, a race condition occurred when posting a message: if the bus notification was received before the result of the message post RPC, the unread counter was set to the number of messages in the channel. This occurs because the `discuss.channel.member/seen` notification is processed before the `discuss.channel/new_message` one so the message is not yet inserted in `thread.messages`. Actually, the channel seen notification is not needed in this case: the last seen message of the author is the message received in the new message notification. Steps to reproduce the issue: - Go to discuss as admin - Open a chat with demo - Set network throttling to "fast 3g" - Send a message in the chat - The unread counter is now set to "1" which is incorrect closes #159190 X-original-commit: 4a57322 Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, a race condition occurred when posting a message: if the bus notification was received before the result of the message post RPC, the unread counter was set to the number of messages in the channel.
This occurs because the
discuss.channel.member/seennotification is processed before thediscuss.channel/new_messageone so the message is not yet inserted inthread.messages.Steps to reproduce the issue:
Forward-Port-Of: #158087