Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pos_self_order,pos_self_order: load self orders in restaurant #159279

Closed
wants to merge 2 commits into from

Conversation

davidmonnom
Copy link
Contributor

@davidmonnom davidmonnom commented Mar 26, 2024

Commit 1

Before, orders from the self order were not loaded in the restaurant. This was due to a typo in the context table_ids variable. The context contains table_ids and the backend attempts to have table_id

This commit fixes the typo and adds the missing table_ids in the context when loading the orders from the self order.

Other fix:

  • The order widget always showing 0 for the total amount of the order, this was due to a wrong variable name price_unit when price was intended.

taskId: 3829268


Commit 2:

When syncing a table to get new self orders from the server, the PoS
was overriding the server's order with the local one, which was
incorrect. This commit fixes this issue by only updating the local
order with the server's one.

Before, orders from the self order were not loaded in the restaurant.
This was due to a typo in the context `table_ids` variable. The context
contains `table_ids` and the backend attempts to have `table_id`

This commit fixes the typo and adds the missing `table_ids` in the
context when loading the orders from the self order.

Other fix:
- The order widget always showing 0 for the total amount of the order,
this was due to a wrong variable name `price_unit` when `price` was
intended.

taskId: 3829268
@robodoo
Copy link
Contributor

robodoo commented Mar 26, 2024

@caburj caburj self-requested a review March 26, 2024 11:17
@C3POdoo C3POdoo requested a review from a team March 26, 2024 11:32
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 26, 2024
When syncing a table to get new self orders from the server, the PoS
was overriding the server's order with the local one, which was
incorrect. This commit fixes this issue by only updating the local
order with the server's one.
@caburj
Copy link
Contributor

caburj commented Mar 27, 2024

robodoo r+

@caburj
Copy link
Contributor

caburj commented Mar 27, 2024

robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Mar 28, 2024
Before, orders from the self order were not loaded in the restaurant.
This was due to a typo in the context `table_ids` variable. The context
contains `table_ids` and the backend attempts to have `table_id`

This commit fixes the typo and adds the missing `table_ids` in the
context when loading the orders from the self order.

Other fix:
- The order widget always showing 0 for the total amount of the order,
this was due to a wrong variable name `price_unit` when `price` was
intended.

Taskid: 3829268
Part-of: #159279
robodoo pushed a commit that referenced this pull request Mar 28, 2024
When syncing a table to get new self orders from the server, the PoS
was overriding the server's order with the local one, which was
incorrect. This commit fixes this issue by only updating the local
order with the server's one.

closes #159279

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 28, 2024
Before, orders from the self order were not loaded in the restaurant.
This was due to a typo in the context `table_ids` variable. The context
contains `table_ids` and the backend attempts to have `table_id`

This commit fixes the typo and adds the missing `table_ids` in the
context when loading the orders from the self order.

Other fix:
- The order widget always showing 0 for the total amount of the order,
this was due to a wrong variable name `price_unit` when `price` was
intended.

Taskid: 3829268
Part-of: #159279
robodoo pushed a commit that referenced this pull request Mar 28, 2024
When syncing a table to get new self orders from the server, the PoS
was overriding the server's order with the local one, which was
incorrect. This commit fixes this issue by only updating the local
order with the server's one.

closes #159279

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
@robodoo robodoo closed this Mar 28, 2024
@robodoo robodoo added the 17.3 label Mar 28, 2024
@fw-bot fw-bot deleted the master-self_order_fix-moda branch April 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants