New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] pos_self_order,pos_self_order: load self orders in restaurant #159279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, orders from the self order were not loaded in the restaurant. This was due to a typo in the context `table_ids` variable. The context contains `table_ids` and the backend attempts to have `table_id` This commit fixes the typo and adds the missing `table_ids` in the context when loading the orders from the self order. Other fix: - The order widget always showing 0 for the total amount of the order, this was due to a wrong variable name `price_unit` when `price` was intended. taskId: 3829268
caburj
reviewed
Mar 27, 2024
addons/pos_restaurant/static/src/app/floor_screen/floor_screen.js
Outdated
Show resolved
Hide resolved
When syncing a table to get new self orders from the server, the PoS was overriding the server's order with the local one, which was incorrect. This commit fixes this issue by only updating the local order with the server's one.
davidmonnom
force-pushed
the
master-self_order_fix-moda
branch
from
March 27, 2024 12:59
b55ab5b
to
392a349
Compare
robodoo r+ |
robodoo rebase-ff |
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Before, orders from the self order were not loaded in the restaurant. This was due to a typo in the context `table_ids` variable. The context contains `table_ids` and the backend attempts to have `table_id` This commit fixes the typo and adds the missing `table_ids` in the context when loading the orders from the self order. Other fix: - The order widget always showing 0 for the total amount of the order, this was due to a wrong variable name `price_unit` when `price` was intended. Taskid: 3829268 Part-of: #159279
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
When syncing a table to get new self orders from the server, the PoS was overriding the server's order with the local one, which was incorrect. This commit fixes this issue by only updating the local order with the server's one. closes #159279 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Before, orders from the self order were not loaded in the restaurant. This was due to a typo in the context `table_ids` variable. The context contains `table_ids` and the backend attempts to have `table_id` This commit fixes the typo and adds the missing `table_ids` in the context when loading the orders from the self order. Other fix: - The order widget always showing 0 for the total amount of the order, this was due to a wrong variable name `price_unit` when `price` was intended. Taskid: 3829268 Part-of: #159279
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
When syncing a table to get new self orders from the server, the PoS was overriding the server's order with the local one, which was incorrect. This commit fixes this issue by only updating the local order with the server's one. closes #159279 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
Before, orders from the self order were not loaded in the restaurant. This was due to a typo in the context
table_ids
variable. The context containstable_ids
and the backend attempts to havetable_id
This commit fixes the typo and adds the missing
table_ids
in the context when loading the orders from the self order.Other fix:
price_unit
whenprice
was intended.taskId: 3829268
Commit 2:
When syncing a table to get new self orders from the server, the PoS
was overriding the server's order with the local one, which was
incorrect. This commit fixes this issue by only updating the local
order with the server's one.