[FIX] project_purchase : fetch purchase order on smart button #159345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoba-odoo
force-pushed
the
saas-17.1-opw-3794848-purchase_order_smart_button-yoba
branch
from
d4deaca
to
667a583
Compare
xavierbol
reviewed
Mar 28, 2024
yoba-odoo
force-pushed
the
saas-17.1-opw-3794848-purchase_order_smart_button-yoba
branch
from
667a583
to
56bc6b9
Compare
svs-odoo
reviewed
Apr 4, 2024
Steps to reproduce: 1- Create a purchase order and assign a project to its Analytic distribution 2- Go to the assigned project's 'Project Updates' 3- Click on Purchase order smart button Current behavior before PR: When trying to view the purchase orders linked to a project you will either get a message saying this ID doesn't exist or you will get an empty list view. This is happening because we are fetching the purchase order line ids and passing those ids to the view not the ids for the purchase order itself https://github.com/odoo/odoo/blob/saas-17.1/addons/project_purchase/models/project_project.py#L31:L33 Desired behavior after PR is merged: We are now passing the ids of the purchase order to the view. opw-3794848
yoba-odoo
force-pushed
the
saas-17.1-opw-3794848-purchase_order_smart_button-yoba
branch
from
56bc6b9
to
8e63120
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 5, 2024
Steps to reproduce: 1- Create a purchase order and assign a project to its Analytic distribution 2- Go to the assigned project's 'Project Updates' 3- Click on Purchase order smart button Current behavior before PR: When trying to view the purchase orders linked to a project you will either get a message saying this ID doesn't exist or you will get an empty list view. This is happening because we are fetching the purchase order line ids and passing those ids to the view not the ids for the purchase order itself https://github.com/odoo/odoo/blob/saas-17.1/addons/project_purchase/models/project_project.py#L31:L33 Desired behavior after PR is merged: We are now passing the ids of the purchase order to the view. opw-3794848 closes #159345 Signed-off-by: Steve Van Essche <svs@odoo.com>
fw-bot
deleted the
saas-17.1-opw-3794848-purchase_order_smart_button-yoba
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
1- Create a purchase order and assign a project to its Analytic distribution
2- Go to the assigned project's 'Project Updates'
3- Click on Purchase order smart button
Current behavior before PR:
When trying to view the purchase orders linked to a project you will either get a message saying this ID doesn't exist or you will get an empty list view. This is happening because we are fetching the purchase order line ids and passing those ids to the view not the ids for the purchase order itself
https://github.com/odoo/odoo/blob/saas-17.1/addons/project_purchase/models/project_project.py#L31:L33
Desired behavior after PR is merged:
We are now passing the ids of the purchase order to the view.
opw-3794848
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr